Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSBTView for memory efficient PSBT handling #2

Open
ghost opened this issue Jul 25, 2021 · 4 comments
Open

Use PSBTView for memory efficient PSBT handling #2

ghost opened this issue Jul 25, 2021 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@ghost
Copy link

ghost commented Jul 25, 2021

No description provided.

@ghost ghost added the enhancement New feature or request label Jul 28, 2021
@ghost
Copy link
Author

ghost commented Mar 1, 2022

This was a bigger problem when the firmware was larger and the full SRAM wasn't being taken advantage of, so I'm going to close this issue for now until (if?) it starts to becomes a problem again.

@ghost ghost closed this as completed Mar 1, 2022
odudex referenced this issue in odudex/krux Mar 20, 2023
@ghost ghost reopened this Aug 18, 2023
@ghost
Copy link
Author

ghost commented Aug 18, 2023

See here for more discussion

@ghost ghost added this to the Next Release milestone Oct 5, 2023
@odudex
Copy link
Member

odudex commented May 27, 2024

We have made several improvements to RAM management, allowing for the signing of larger transactions. For instance, transactions with up to 100 inputs can now be signed using QR codes, and those with up to 145 inputs can be signed using SD cards.
Additionally, we have optimized flash management, reducing its usage frequency and making its content smaller and more predictable. At this time, we prefer to avoid using PSBTView, as it would significantly increase flash usage and leave behind large amounts of data.
Yet, PSBTView remains as a ace up one's sleeve in case we need to sign larger transactions.

@tadeubas
Copy link
Contributor

Could we increase the heap size a little again? I think the transaction used was from a single-sig wallet, IMHO it is necessary to pass all [lopp tests on HW signing performance](https://blog.casa.io/bitcoin-multisig-hardware-signing - performance-2024/) and be able to withstand at least 50% more, what do you think?

odudex pushed a commit that referenced this issue Jul 2, 2024
Merge with develop (fixed conflicts)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants