Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kube options #168

Merged
merged 23 commits into from
Dec 20, 2021
Merged

Update kube options #168

merged 23 commits into from
Dec 20, 2021

Conversation

pavelpereyma
Copy link
Contributor

@pavelpereyma pavelpereyma commented Aug 30, 2021 •
edited
Loading

Support MKS Cluster feature gates & admission controllers #166 .
Added data sources that could be using to get available feature gates or admission controllers for the specific Kubernetes versions:

  • selectel_mks_available_feature_gates_v1
  • selectel_mks_available_admission_controllers_v1

Updated dependencies:

  • github.com/hashicorp/terraform-plugin-sdk/v2 -> v2.7.0
  • github.com/selectel/mks-go -> v0.8.0

@pavelpereyma
Revert back changelog
9dea259
@pavelpereyma
Merge branch 'master' into update-kube-options
d790a55 
# Conflicts:
#	CHANGELOG.md
#	go.mod
#	selectel/provider.go
@pavelpereyma pavelpereyma marked this pull request as ready for review October 27, 2021 14:08
kolsean
kolsean requested changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad! But we need to make some changes.

selectel/provider.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/resource_selectel_mks_cluster_v1_test.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/resource_selectel_mks_cluster_v1_test.go Show resolved Hide resolved
@pavelpereyma
Copy link
Contributor Author

Thank you for your review. I made necessary changes, please review changes and back if need something to fix.

kolsean
kolsean requested changes Nov 12, 2021
View reviewed changes
Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to create new data source with feature gates an internal error occured:
Error: Invalid address to set: []string{"feature_gates", "0", "kube_version_minor"}
Please check.

Also there is no documentation for new data sources.
Please add the doc.

selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options_test.go Outdated Show resolved Hide resolved
selectel/kube_options.go Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Show resolved Hide resolved
@pavelpereyma pavelpereyma requested a review from kolsean November 16, 2021 13:51
kolsean
kolsean requested changes Nov 19, 2021
View reviewed changes
.github/workflows/acceptance-tests.yml Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options.go Outdated Show resolved Hide resolved
selectel/data_source_selectel_mks_kube_options_test.go Outdated Show resolved Hide resolved
selectel/resource_selectel_mks_cluster_v1_test.go Outdated Show resolved Hide resolved
website/docs/d/mks_feature_gates_v1.html.markdown Outdated Show resolved Hide resolved
website/docs/r/mks_cluster_v1.html.markdown Outdated Show resolved Hide resolved
website/docs/d/mks_feature_gates_v1.html.markdown Show resolved Hide resolved
@pavelpereyma
Refactor mks cluster tests with kube options;
d743f43 
Rename kube_version_minor -> kube_version;

Update website docs;

Revert back go test flag.
@pavelpereyma pavelpereyma requested a review from kolsean November 20, 2021 13:14
kolsean
kolsean requested changes Nov 22, 2021
View reviewed changes
Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few linter and doc issues left to fix.
dupl threshold in the linters settings can be raised to 300

selectel/resource_selectel_mks_cluster_v1_test.go Outdated Show resolved Hide resolved
selectel/resource_selectel_mks_cluster_v1_test.go Outdated Show resolved Hide resolved
selectel/resource_selectel_mks_cluster_v1_test.go Outdated Show resolved Hide resolved
website/docs/d/mks_admission_controllers_v1.html.markdown Outdated Show resolved Hide resolved
website/docs/d/mks_feature_gates_v1.html.markdown Outdated Show resolved Hide resolved
@pavelpereyma pavelpereyma requested a review from kolsean November 23, 2021 06:24
@pavelpereyma
Rename test cluster update function;
7b4b8c8 
Refactor getting MKS client in tests
@pavelpereyma pavelpereyma requested a review from kolsean November 24, 2021 14:38
kolsean
kolsean approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kolsean kolsean merged commit 22f58a9 into selectel:master Dec 20, 2021
@kolsean kolsean mentioned this pull request Dec 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolsean kolsean kolsean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelpereyma @kolsean