Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetParsedKubeconfig function #60

Merged
merged 6 commits into from
Nov 24, 2021
Merged

Conversation

dkder3k
Copy link
Contributor

@dkder3k dkder3k commented Oct 25, 2021

To implement data sources for tf provider requested in selectel/terraform-provider-selectel#145

Also Earthfile for earthly added in this pr as it is hard nowadays to reproduce TravisCI run locally without containers.

@dkder3k dkder3k requested a review from kolsean October 25, 2021 19:10
@dkder3k dkder3k force-pushed the parse-kubeconfig branch 4 times, most recently from 2c46407 to dd34a1e Compare November 17, 2021 19:20
Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
Everything is good, but some changes need to be made.

pkg/v1/cluster/testing/requests_test.go Outdated Show resolved Hide resolved
pkg/v1/cluster/testing/requests_test.go Outdated Show resolved Hide resolved
pkg/v1/cluster/testing/requests_test.go Outdated Show resolved Hide resolved
pkg/v1/cluster/requests.go Show resolved Hide resolved
pkg/v1/cluster/requests.go Outdated Show resolved Hide resolved
pkg/v1/cluster/requests.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@kolsean kolsean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kolsean kolsean merged commit c60e179 into selectel:master Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants