-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetParsedKubeconfig function #60
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkder3k
force-pushed
the
parse-kubeconfig
branch
from
October 25, 2021 19:33
982b980
to
7b6d0d0
Compare
dkder3k
force-pushed
the
parse-kubeconfig
branch
4 times, most recently
from
November 17, 2021 19:20
2c46407
to
dd34a1e
Compare
dkder3k
force-pushed
the
parse-kubeconfig
branch
from
November 17, 2021 19:56
dd34a1e
to
ec226a7
Compare
kolsean
requested changes
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
Everything is good, but some changes need to be made.
kolsean
requested changes
Nov 22, 2021
kolsean
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement data sources for tf provider requested in selectel/terraform-provider-selectel#145
Also Earthfile for earthly added in this pr as it is hard nowadays to reproduce TravisCI run locally without containers.