Add TypeScript definitions #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the PR segmentio#50 merged in 7119bcc
|
I can confirm this resolves the issue. |
Closed
|
Please merge |
|
what is the blocker to merge this? |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 33 33
Branches 11 11
=========================================
Hits 33 33 Continue to review full report at Codecov.
|
juliofarah
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Thanks @JackCuthbert for your contribution and I'm sorry we took so long to review this pull request.
I'm merging this and creating a new version right now!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We'd like to use this library in a Next.js application that we're building with TypeScript but it complains that there is no type declarations for the module. This PR adds a TypeScript declaration for the
@segment/snippetmodule.I've also documented the
ajsPathoption from #50 merged in 7119bcc.Preview
Editor/tsserver integration working
Testing
I've verified that this works with
npm linkin our TypeScript project locally. There are no functionality changes so I expect this would work when published as long as thetypes.d.tsfile is included in the package.