Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for protocol relative url #7

Merged
merged 1 commit into from
Nov 25, 2014
Merged

add support for protocol relative url #7

merged 1 commit into from
Nov 25, 2014

Conversation

sindresorhus
Copy link
Contributor

@zeke
Copy link
Contributor

zeke commented Jul 2, 2014

👍

1 similar comment
@shinnn
Copy link

shinnn commented Jul 18, 2014

+1

@sindresorhus
Copy link
Contributor Author

ping @ianstormtaylor

@sindresorhus
Copy link
Contributor Author

Since nobody seems to care here. You're better off using: https://github.com/kevva/url-regex

@zeke
Copy link
Contributor

zeke commented Nov 21, 2014

I'd happily maintain this repo if @ianstormtaylor wants to collab me.

@sindresorhus
Copy link
Contributor Author

Ideally this module should just depend on url-regex as its regex is a lot better.

@ianstormtaylor
Copy link
Contributor

Sorry, missed this. @zeke added you as a collab on GitHub and npm!

@zeke
Copy link
Contributor

zeke commented Nov 22, 2014

Thanks @ianstormtaylor!

I just cloned the repo and tried to push a branch, but I'm getting dissed. Am I missing something?

is-url use-url-regex » git push -u origin use-url-regex
remote: Permission to segmentio/is-url.git denied to ad8844afd9bee1aa340101879d182781f1c7357a.
fatal: unable to access 'https://github.com/segmentio/is-url/': The requested URL returned error: 403

is-url use-url-regex » git remote -v                   
origin  https://github.com/segmentio/is-url (fetch)
origin  https://github.com/segmentio/is-url (push)

is-url use-url-regex » git remote -v
origin  git@github.com:segmentio/is-url.git (fetch)
origin  git@github.com:segmentio/is-url.git (push)

is-url use-url-regex » git push -u origin use-url-regex
ERROR: Permission to segmentio/is-url.git denied to zeke.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@zeke
Copy link
Contributor

zeke commented Nov 22, 2014

nm, I forgot that github sends confirmation emails now.

@sindresorhus, see #9

@zeke zeke closed this Nov 22, 2014
@sindresorhus sindresorhus deleted the protocol-less-url branch November 22, 2014 05:11
@sindresorhus sindresorhus restored the protocol-less-url branch November 25, 2014 07:37
ianstormtaylor added a commit that referenced this pull request Nov 25, 2014
add support for protocol relative url
@ianstormtaylor ianstormtaylor merged commit 4552d37 into segmentio:master Nov 25, 2014
@ianstormtaylor
Copy link
Contributor

Thanks for this, published as 1.2.0 despite the wrong commit name because for reason rebase is erroring out right now locally.

Happy holidays.

@sindresorhus sindresorhus deleted the protocol-less-url branch November 26, 2014 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants