latest patch version (1.2.3) changes behavior if string is undefined #19
Comments
davisjam
added a commit
to davisjam/is-url
that referenced
this issue
Mar 24, 2018
Problem: As reported in segmentio#19, PR segmentio#18 changed behavior on: - undefined string - non-strings Solution: Revert to pre-segmentio#18 behavior on non-strings: return false. Test: I added test cases to clarify this behavior. It shouldn't happen again.
Merged
|
@sballesteros @cadente-nd Thank you for pointing this out. This is a bug in #18. I was trying to keep all existing behavior the same, but there was no test case for this so I missed it. #20 will fix this issue. |
davisjam
added a commit
to davisjam/is-url
that referenced
this issue
Mar 26, 2018
Problem: As reported in segmentio#19, PR segmentio#18 changed behavior on: - undefined string - non-strings Solution: Revert to pre-segmentio#18 behavior on non-strings: return false. Test: I added test cases to clarify this behavior. It shouldn't happen again.
|
@sballesteros If #20 solves your problem, can you close this issue? #20 is available in is-url version 1.2.4 on npm. |
|
@davisjam thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The change from
re.test(string)tostring.match(re)result in a different behavior ifstringis undefined (calling.teston undefined will throw a TypeError).Maybe put a guard like
if (typeof string == 'string') return falseto avoid that or consider bumping the major version as 1.2.3 can be considered as a change introducing a breaking change.The text was updated successfully, but these errors were encountered: