Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more selective about signal redaction #1106

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Be more selective about signal redaction #1106

merged 6 commits into from
Sep 30, 2024

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Jul 10, 2024 •
edited
Loading

  • only redact 'target.value' in interaction signals
  • do not redact instrumentation signals or navigation signals

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e0478f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MichaelGHSeg
MichaelGHSeg previously approved these changes Jul 10, 2024
View reviewed changes
@silesky silesky marked this pull request as draft July 10, 2024 23:52
@silesky silesky marked this pull request as ready for review September 27, 2024 19:57
@silesky silesky merged commit e0e8d0f into master Sep 30, 2024
6 checks passed
@silesky silesky deleted the signals-only-obf-values branch September 30, 2024 21:06
@github-actions github-actions bot mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjcharles alanjcharles alanjcharles approved these changes

@MichaelGHSeg MichaelGHSeg MichaelGHSeg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silesky @alanjcharles @MichaelGHSeg