Node: deprecate maxEventsInBatch in favor of flushAt
#1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 91493c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
changed the title
maxEventsInBach to flushAt
silesky
changed the title
maxEventsInBach to flushAtmaxEventsInBatch in favor of flushAt
chrisradek
reviewed
Jan 3, 2024
.changeset/fifty-trains-act.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@segment/analytics-node': major | |||
There was a problem hiding this comment.
Might want to coordinate with @MichaelGHSeg to add the breaking changes he needs to make for oauth so they both get included when we bump this (if you haven't coordinated already)
There was a problem hiding this comment.
I did some internet research and the SemVar specification specifically says to bump the minor version for deprecation, so updated!
silesky
force-pushed
the
node-add-flush-at
branch
from
7ce0d51
to
03b3f90
Compare
chrisradek
approved these changes
Jan 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
maxEventsInBatchin favor offlushAt. The purpose is to establish consistency between our SDKs, regardless of language.(Basically, let's go back to the original naming of maxEventsInBatch)
Docs Change: segmentio/segment-docs#5808