Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create-release script to work with any CWD #1013

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Dec 11, 2023

Publishing is broken (when running a workspace command, CWD is set to the package, rather than the root). It should now work regardless of where the script is called from.

Can be tested by doing:

DRY_RUN=1 TAGS=@segment/analytics-next@1.61.0 yarn ts-node-script scripts/create-release-from-tags/run.ts
DRY_RUN=1 TAGS=@segment/analytics-next@1.61.0 yarn scripts create-release-from-tags

Copy link

changeset-bot bot commented Dec 11, 2023

⚠️ No Changeset found

Latest commit: 1d62e21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@silesky silesky changed the title update scripts to use relative path Fix create-release script to work with any CWD Dec 11, 2023
@silesky silesky merged commit a8b2a23 into master Dec 11, 2023
6 checks passed
@silesky silesky deleted the update-scripts-to-use-relative-path branch December 11, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants