wip

segmentio · Oct 30, 2024 · 1de5c29 · 1de5c29
1 parent b5763cc
commit 1de5c29
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 18 deletions.
diff --git a/.changeset/little-chefs-hunt.md b/.changeset/little-chefs-hunt.md
@@ -0,0 +1,8 @@
+---
+'@segment/analytics-signals': minor
+---
+- Fix runtime errors for submit
+- Add better form submit data 
+- Loosen content-type to parse text/plain
+- Tweak disallow list
+- Add labels
diff --git a/...ignals/signals/src/core/signal-generators/network-gen/__tests__/network-generator.test.ts b/...ignals/signals/src/core/signal-generators/network-gen/__tests__/network-generator.test.ts
@@ -142,24 +142,6 @@ describe(NetworkGenerator, () => {
     await sleep(100)
     expect(mockEmitter.emit.mock.calls).toMatchInlineSnapshot(`
       [
-        [
-          {
-            "data": {
-              "action": "request",
-              "contentType": "text/html",
-              "data": "hello world",
-              "method": "GET",
-              "url": "http://localhost/api",
-            },
-            "metadata": {
-              "filters": {
-                "allowed": [],
-                "disallowed": [],
-              },
-            },
-            "type": "network",
-          },
-        ],
         [
           {
             "data": {

diff --git a/packages/signals/signals/src/core/signals/signals.ts b/packages/signals/signals/src/core/signals/signals.ts
@@ -90,6 +90,9 @@ export class Signals implements ISignals {
       disallowListURLs: [
         analyticsService.instance.settings.apiHost,
         analyticsService.instance.settings.cdnURL,
+        'api.segment.io',
+        'signals.segment.io',
+        'cdn.segment.com',
       ],
       sampleRate:
         analyticsService.instance.settings.cdnSettings