Skip to content

new Dub Destination #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

new Dub Destination #2911

merged 1 commit into from
May 20, 2025

Conversation

joe-ayoub-segment
Copy link
Contributor

Added new Dub Destination

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link
Contributor

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Dub (Actions), Settings:apiKey
  • Destination: Dub (Actions), Action:trackLead, Fields:clickId,eventName,externalId
  • Destination: Dub (Actions), Action:trackSale, Fields:externalId,amount,paymentProcessor

Add these new fields as optional instead and assume default values in perform or performBatch block.

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.13%. Comparing base (7d4dee8) to head (dd9601a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
+ Coverage   78.11%   78.13%   +0.01%     
==========================================
  Files        1050     1054       +4     
  Lines       19438    19452      +14     
  Branches     3735     3735              
==========================================
+ Hits        15184    15198      +14     
  Misses       2972     2972              
  Partials     1282     1282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@devkiran
Copy link

@joe-ayoub-segment Any ETA on when this PR will be merged?

@joe-ayoub-segment
Copy link
Contributor Author

hi @devkiran this PR is due to be deployed tomorrow (Tuesday) afternoon US time.

@devkiran
Copy link

@joe-ayoub-segment Appreciate the update! We're excited to see this go live soon!

@joe-ayoub-segment joe-ayoub-segment merged commit c79e102 into main May 20, 2025
11 of 12 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the dub-destination branch May 20, 2025 15:26
@joe-ayoub-segment
Copy link
Contributor Author

PR deployed. Email to follow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants