-
Notifications
You must be signed in to change notification settings - Fork 279
new Dub Destination #2911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new Dub Destination #2911
Conversation
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
+ Coverage 78.11% 78.13% +0.01%
==========================================
Files 1050 1054 +4
Lines 19438 19452 +14
Branches 3735 3735
==========================================
+ Hits 15184 15198 +14
Misses 2972 2972
Partials 1282 1282 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@joe-ayoub-segment Any ETA on when this PR will be merged? |
hi @devkiran this PR is due to be deployed tomorrow (Tuesday) afternoon US time. |
@joe-ayoub-segment Appreciate the update! We're excited to see this go live soon! |
PR deployed. Email to follow |
Added new Dub Destination
Testing