Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets anonymousId on track via Adjust's addPartnerParam method #10

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

ladanazita
Copy link
Contributor

@ladanazita ladanazita commented Aug 30, 2017

Attribution data being sent back from Adjust is silently failing (since Segment requires one unique identifier (whether a userId or anonymousId on all calls), and the only way to send Adjust the Segment userId or anonymousId is through the setSessionPartnerParameter method, which we only mapped on identify. This now sets the anonymousId on all track events, so Segment can receive the Install Attributed event with the anonymousId attached.

We decided not to map userId because

  1. analytics-ios does not have a getter function to retrieve the userId. We would have had to store to disc which take more time to implement, and this fix is urgent
  2. Since the issue is around attribution events not having one of the required fields prior to identify being called, the anonymousId will be the only value present since identify has not been called and thus the userId has not been set

For Surfline, JIRA ticket here

Copy link
Contributor

@f2prateek f2prateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ladanazita ladanazita merged commit bfb6e62 into master Aug 30, 2017
@ladanazita ladanazita deleted the maps/partner-params branch August 30, 2017 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants