Skip to content

Commit

Permalink
fix(ui): fixes empty string value in pipeline parameters (kubeflow#11175
Browse files Browse the repository at this point in the history
)

Signed-off-by: Jan Staněk <jan@jstanek.cz>
Co-authored-by: Jan Staněk <jan.stanek2@firma.seznam.cz>
  • Loading branch information
2 people authored and sefgsefg committed Sep 20, 2024
1 parent ea2ba01 commit e101bf1
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions frontend/src/components/NewRunParametersV2.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,7 @@ const protoMap = new Map<string, string>([
]);

function convertInput(paramStr: string, paramType: ParameterType_ParameterTypeEnum): any {
// TBD (jlyaoyuli): Currently, empty string is not allowed.
if (paramStr === '') {
if (paramStr === '' && paramType !== ParameterType_ParameterTypeEnum.STRING) {
return undefined;
}
switch (paramType) {
Expand Down

0 comments on commit e101bf1

Please sign in to comment.