Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROG Ally key bindings improvement #3549

Closed
2 tasks done
szabomisu opened this issue Jan 4, 2025 · 10 comments
Closed
2 tasks done

ROG Ally key bindings improvement #3549

szabomisu opened this issue Jan 4, 2025 · 10 comments
Labels
question Further information is requested

Comments

@szabomisu
Copy link

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

First of all, thank you for this amazing app, truly a much better replacement for Armoury Crate!

The only thing I would love to see improved on are the key bindings on the ROG Ally. In the current version 0.200.0 I can't map any of these:

  • I would like to use the Control Center key for Steam (Xbox/Guide button).
  • It would be great to have secondary functions for the AC and CC buttons.
  • I would like to map the secondary function of the View button to Task View (Win+Tab).
  • Also to map the Toggle Touchscreen to any button (Secondary left stick for my taste).

Also it's a bit weird that the standard bindings doesn't show up in the controller menu. For example X button secondary is screenshot, but I only found it out from Github, it shows unnasigned in the bindings.

One more thing: Just nitpicking but the Run on Startup checkbox count go in the Extra menu Others, we really don't need it in the main window.

Describe the solution you'd like

I don't know if the AC, CC and back paddle button bindings are on purpose separately in the Extra menu and have different binding options than the ones in the Controller menu, but I think it would be better if they would all be in one place (in the Controller menu) and have the same options, with secondary option, custom actions and all.

As it is the back paddles are also in two places, they can be mapped in the Controller menu separately as M1 and M2, it would be better to have just the ladder but with all options. And the predefined bindings could be showing up instead of the -------- unassigned dashes for the ones that have them.

Describe alternatives you've considered

Alternatively the AC and CC key bindings could stay in the Extra menu with added secondary mapping and all the binding options that the other buttons have. And vice versa the Contoller menu bindings should have the same options as the ones in the Extra menu.

I hope I got the ideas across, feel free to reach out if something is not clear!

Device and Model

Asus ROG Ally Z1 Extreme

Additional information.

{1370881A-F859-4D77-9859-7FB444AB692D}

@seerge
Copy link
Owner

seerge commented Jan 4, 2025

@szabomisu hello,

I would like to use the Control Center key for Steam (Xbox/Guide button).
It would be great to have secondary functions for the AC and CC buttons.

AC and CC buttons are not part of build in "controller", so unfortunately they can't be mapped to those actions. Please check another duplicate issue where I have explained reasons in detail

I would like to map the secondary function of the View button to Task View (Win+Tab).
Also to map the Toggle Touchscreen to any button (Secondary left stick for my taste).

This should be possible, I have added 2 new actions for Controller section - Win+Tab and Toggle TouchScreen. You should be able to assign them to any controller primary or secondary key.

Try this build

GHelper.zip

Thanks

@seerge seerge added the question Further information is requested label Jan 4, 2025
@seerge
Copy link
Owner

seerge commented Jan 4, 2025

Also it's a bit weird that the standard bindings doesn't show up in the controller menu. For example X button secondary is screenshot, but I only found it out from Github, it shows unnasigned in the bindings.

P.S. This actually has a reason.

Default bindings for some keys are different for Mouse / Gamepad modes (like Right Trigger is Mouse Click in Mouse, and an actual Trigger in Gamepad). And "custom" bindings are universal for both modes at the moment. So not to confuse people I decided not to show anything under Controller section unless button is assigned by the end user.

This may change when I will finally find time and implement different binding profiles for Gamepad and Mouse modes :)

@szabomisu
Copy link
Author

szabomisu commented Jan 4, 2025 via email

@szabomisu
Copy link
Author

szabomisu commented Jan 4, 2025 via email

seerge added a commit that referenced this issue Jan 5, 2025
@seerge
Copy link
Owner

seerge commented Jan 5, 2025

@szabomisu hello,

Try this build for Touchscreen toggle
GHelper.zip

As for power limit sliders are not supposed to move somewhere on reset. Unless Apply is checked - they have no effect.

@szabomisu
Copy link
Author

szabomisu commented Jan 5, 2025 via email

@seerge
Copy link
Owner

seerge commented Jan 5, 2025

@szabomisu

Can you bind something to the left stick using Armoury Crate ? Cause whole binding happens on firmware level. And furthermore - binding commands do buttons in pair. And Right + Left stick clicks is a single command.

It is impossible to "read" default power limits (Asus firmware does not report them). This is general behavior for all Asus devices, laptops and ally.

That's why whole Apply checkbox exists in first place. Unless it's checked - no custom limits are added, and system uses defaults (whatever they are for your specific device)

@szabomisu
Copy link
Author

szabomisu commented Jan 5, 2025 via email

@seerge
Copy link
Owner

seerge commented Jan 5, 2025

@szabomisu i have tested it on my Ally, and it's indeed seems like M+Left Stick can't be remapped. It looks like a firmware limitation, as M+Right Stick works just fine :)

Luckily you have lots of other buttons to use tho.

Thanks

@seerge seerge closed this as completed Jan 5, 2025
@szabomisu
Copy link
Author

szabomisu commented Jan 5, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants