Maintenance Fixing Build Errors and Add Support for Python 3.7 & 3.8 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link for http://www.numpy.org redirects to https://numpy.org. Also updated repeated numpy links to reference original named hyper-link, as NumPy_, rather than repeating link address. See http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#hyperlink-references for more details about using the named hyper-link reference.
Fixed typos for for words 'spherical', 'axis', and 'coercion'
Making __array_wrap__ static, allows the no-self-use pylint warning to be removed.
Both of these errors coming from inheriting from np.ndarray, and np.ndarray has a dot method with different parameters.
- Replaced the depreciated np.asscalar function with np.ndarray.item - Use builtin sum function for calculating dot product in BaseVectorArray.dot rather than np.sum. Using np.sum on a generator is depreciated, and will change behavior in the future (per numpy documentation)
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 90.64% 91.47% +0.82%
==========================================
Files 2 2
Lines 310 340 +30
==========================================
+ Hits 281 311 +30
Misses 29 29
Continue to review full report at Codecov.
|
|
Also related to this PR, I wanted to bring up Python 2 support. Are there plans to drop it, or do you plan to support it indefinitely? If dropping it is planned, I would be happy to get started on that with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Travis build errors for python 3.5 and 3.6 by fixing sphinx errors/warnings.
Also included are fixed typos/spelling errors in README and doc-strings, and adding support for Python 3.7 and 3.8.