Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #975

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Version Packages #975

merged 1 commit into from
Nov 9, 2022

Conversation

seek-oss-ci
Copy link
Contributor

@seek-oss-ci seek-oss-ci commented Sep 20, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

skuba@5.0.0

Major Changes

  • test: Remove default src module alias (#987)

    Our Jest preset automatically registers your tsconfig.json paths as module aliases, but would previously fall back to the src alias if the option was omitted or failed to load. This default has now been removed.

    This is not expected to affect most projects. If yours makes use of the src alias and its tests are now failing on imports like the following:

    import { app } from 'src/app.ts';

    Ensure that you declare this path in a tsconfig.json located in your project root:

    {
      "compilerOptions": {
    +   "paths": {
    +     "src": ["src"]
    +   }
      },
      "extends": "skuba/config/tsconfig.json"
    }
  • build, test: Default to isolated modules (#987)

    Our Jest and TypeScript presets now enable isolatedModules by default. Your Jest tests should start quicker, consume less resources, and no longer get stuck on pesky type errors. This should not compromise the type safety of your project as skuba lint is intended to type check all production and testing code.

    If your project contains files without imports and exports like jest.setup.ts, you can add an empty export statement to them to placate the TypeScript compiler:

    jest.setup.ts(1,1): error TS1208: 'jest.setup.ts' cannot be compiled under '--isolatedModules' because it is considered a global script file. Add an import, export, or an empty 'export {}' statement to make it a module.
    process.env.ENVIRONMENT = 'test';
    
    + export {};

    If you previously enabled isolatedModules via the globals option in your Jest config, this is no longer functional due to syntax changes in ts-jest 29. You should be able to rely on our default going forward. skuba configure can attempt to clean up the stale option, or you can remove it from your jest.config.ts manually:

    export default Jest.mergePreset({
    - globals: {
    -   'ts-jest': {
    -     // seek-oss/skuba#626
    -     isolatedModules: true,
    -   },
    - },
      // Rest of config
    });

    Isolated modules are incompatible with certain language features like const enums. We recommend migrating away from such features as they are not supported by the broader ecosystem, including transpilers like Babel and esbuild. If your project is not yet ready for isolated modules, you can override the default in your tsconfig.json:

    {
      "compilerOptions": {
    +   "isolatedModules": false
      },
      "extends": "skuba/config/tsconfig.json"
    }

Minor Changes

  • format: Sort package.json (#1016)

  • build: Add experimental esbuild support (#681)

    You can now build your project with esbuild. Note that this integration is still experimental, only includes the bare minimum to supplant a basic tsc-based build, and is not guaranteed to match tsc output. See the esbuild deep dive for more information.

    To opt in, modify your package.json:

    {
      "skuba": {
    +   "build": "esbuild",
        "template": null
      }
    }

Patch Changes

  • configure: Fix tsconfig.json#/compilerOptions/lib clobbering (#1031)

  • template: Bump greeter and API templates to Node.js 18 (#1011)

    Node.js 18 is now in active LTS. The Lambda templates are stuck on Node.js 16 until the new AWS Lambda runtime is released.

  • template/lambda-sqs-worker-cdk: Replace Runtypes with Zod as default schema validator (#984)

  • template/lambda-sqs-worker: Replace Runtypes with Zod as default schema validator (#984)

  • configure: Fix package version lookups (#974)

    This resolves the following error:

    Error: Package "xyz" does not have a valid package.json manifest
  • configure: Fix jest.setup.js clobbering (#1031)

  • template/lambda-sqs-worker*: Adjust Buildkite pipelines for new renovate-- branch name prefix (#1022)

    See the pull request that aligns our Renovate presets for more information.

  • template: Support AMD64 Docker builds via BUILDPLATFORM (#1021)

    See the Docker documentation for more information. Note that this does not allow you to build on AMD64 hardware then deploy to ARM64 hardware and vice versa. It is provided for convenience if you need to revert to an AMD64 workflow and/or build and run an image on local AMD64 hardware.

  • template/koa-rest-api: Replace Runtypes with Zod as default schema validator (#984)

@seek-oss-ci seek-oss-ci requested review from a team as code owners September 20, 2022 23:19
@72636c 72636c marked this pull request as draft September 21, 2022 00:46
@72636c 72636c added the dino:snooze Snooze in Review Dino label Sep 21, 2022
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 5 times, most recently from eb6f237 to 552bb99 Compare September 27, 2022 21:47
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 12 times, most recently from ad0e7a6 to 3589db6 Compare October 13, 2022 22:34
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 6 times, most recently from 619f8bd to d99cd4c Compare October 20, 2022 20:45
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 3 times, most recently from 7dbc793 to 6572aa5 Compare October 25, 2022 17:11
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 4 times, most recently from 2a71281 to 314a037 Compare October 30, 2022 23:52
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/master branch 10 times, most recently from 636868a to 7464123 Compare November 8, 2022 20:16
@72636c 72636c marked this pull request as ready for review November 9, 2022 05:08
@72636c 72636c removed the dino:snooze Snooze in Review Dino label Nov 9, 2022
@72636c 72636c enabled auto-merge (squash) November 9, 2022 05:17
Copy link
Member

@72636c 72636c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📿

@72636c 72636c merged commit c38e09b into master Nov 9, 2022
@72636c 72636c deleted the changeset-release/master branch November 9, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants