Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #1506

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Version Packages #1506

merged 1 commit into from
Apr 17, 2024

Conversation

seek-oss-ci
Copy link
Contributor

@seek-oss-ci seek-oss-ci commented Mar 26, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

skuba@8.0.1

Patch Changes

  • deps: eslint 8.56.0 (#1521)

    This upgrade is required for eslint-config-seek 13.

  • template: Install specific pnpm version via Corepack (#1515)

    Previously, our Dockerfiles ran corepack enable pnpm without installing a specific version. This does not guarantee installation of the pnpm version specified in package.json, which could cause a subsequent pnpm install --offline to run Corepack online or otherwise hang on stdin:

    FROM --platform=arm64 node:20-alpine
    
    RUN corepack enable pnpm
    {
      "packageManager": "pnpm@8.15.4",
      "engines": {
        "node": ">=20"
      }
    }
    Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-8.15.4.tgz.
    
    Do you want to continue? [Y/n]

    To avoid this issue, modify (1) Buildkite pipelines to cache on the packageManager property in package.json, and (2) Dockerfiles to mount package.json and run corepack install:

    - seek-oss/docker-ecr-cache#v2.1.0:
    + seek-oss/docker-ecr-cache#v2.2.0:
        cache-on:
         - .npmrc
    +    - package.json#.packageManager
         - pnpm-lock.yaml
    FROM --platform=arm64 node:20-alpine
    
    - RUN corepack enable pnpm
    + RUN --mount=type=bind,source=package.json,target=package.json \
    + corepack enable pnpm && corepack install
  • template/*-rest-api: Fix lint failure (#1514)

    This resolves the following failure on a newly-initialised project due to a regression in the @types/express dependency chain:

    error TS2688: Cannot find type definition file for 'mime'.
      The file is in the program because:
        Entry point for implicit type library 'mime'

    A temporary workaround is to install mime as a dev dependency.

  • deps: @octokit/types ^13.0.0 (#1536)

  • template/lambda-sqs-worker-cdk: Align dead letter queue naming with Serverless template (#1542)

  • Jest.mergePreset: Fudge Bundler module resolution (#1513)

    This extends #1481 to work around a ts-jest issue where test cases fail to run.

  • template/oss-npm-package: Set timeout to 20 minutes for GitHub Actions (#1501)

  • template/lambda-sqs-worker-cdk: Replace CDK context based config with TypeScript config (#1541)

@seek-oss-ci seek-oss-ci requested review from a team as code owners March 26, 2024 02:15
@72636c 72636c marked this pull request as draft March 26, 2024 02:21
Base automatically changed from main to master March 26, 2024 02:23
@72636c 72636c mentioned this pull request Mar 26, 2024
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 6 times, most recently from 1786e5b to a01c47f Compare April 2, 2024 02:38
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 13 times, most recently from ae2ce47 to b00ef52 Compare April 9, 2024 14:56
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 4 times, most recently from 51e3a1b to 5e882a8 Compare April 10, 2024 03:27
@seek-oss-ci seek-oss-ci force-pushed the changeset-release/main branch 6 times, most recently from f76a4ff to c850432 Compare April 17, 2024 00:45
@samchungy samchungy marked this pull request as ready for review April 17, 2024 06:17
@samchungy samchungy requested a review from a team as a code owner April 17, 2024 06:17
@samchungy samchungy merged commit b5d5a58 into main Apr 17, 2024
20 checks passed
@samchungy samchungy deleted the changeset-release/main branch April 17, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants