Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust code for typescript-eslint v6 rules #222

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 15, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
skuba 7.0.1 -> 7.1.1 age adoption passing confidence

Release Notes

seek-oss/skuba (skuba)

v7.1.1

Compare Source

Patch Changes
  • init: Resolve directory path when patching Renovate config (#​1241)

    This should fix the Failed to patch Renovate config. warning when creating a new repo.

v7.1.0

Compare Source

Minor Changes
  • format, lint: Skip autofixing on Renovate branches when there is no open pull request (#​1226)

    This prevents an issue where a Renovate branch can get stuck in the Edited/Blocked state without a pull request being raised.

  • deps: eslint-config-skuba 3 (#​1234)

    This major upgrade brings in new rules from typescript-eslint v6.

    Diff patch from eslint-config-skuba 2 and eslint-config-skuba 3

    {
    +  '@​typescript-eslint/array-type': '...',
    +  '@​typescript-eslint/ban-tslint-comment': '...',
    +  '@​typescript-eslint/class-literal-property-style': '...',
    +  '@​typescript-eslint/consistent-generic-constructors': '...',
    +  '@​typescript-eslint/consistent-indexed-object-style': '...',
    +  '@​typescript-eslint/consistent-type-assertions': '...',
    +  'dot-notation': '...',
    +  '@​typescript-eslint/dot-notation': '...',
    +  '@​typescript-eslint/no-base-to-string': '...',
    +  '@​typescript-eslint/no-confusing-non-null-assertion': '...',
    +  '@​typescript-eslint/no-duplicate-enum-values': '...',
    +  '@​typescript-eslint/no-duplicate-type-constituents': '...',
    +  '@​typescript-eslint/no-redundant-type-constituents': '...',
    +  '@​typescript-eslint/no-unsafe-declaration-merging': '...',
    +  '@​typescript-eslint/no-unsafe-enum-comparison': '...',
    +  '@​typescript-eslint/prefer-for-of': '...',
    +  '@​typescript-eslint/prefer-function-type': '...',
    +  '@​typescript-eslint/prefer-nullish-coalescing': '...',
    +  '@​typescript-eslint/prefer-optional-chain': '...',
    +  '@​typescript-eslint/prefer-string-starts-ends-with': '...',
    -  'no-extra-semi': '...',
    -  '@​typescript-eslint/no-extra-semi': '...',
    }
  • format, lint: Add pnpm-lock.yaml to .prettierignore (#​1225)

  • deps: esbuild 0.19 (#​1236)

  • format, lint: Switch distroless image from nodejs to nodejs-debian11 (#​1224)

    skuba format and skuba lint will now automatically switch your gcr.io/distroless/nodejs:18 image to gcr.io/distroless/nodejs18-debian11. This is now the recommended base image for Node.js.

Patch Changes
  • template/*-rest-api: Switch distroless image from nodejs:18 to nodejs18-debian11 (#​1224)

Configuration

📅 Schedule: Branch creation - "after 3:00 am and before 6:00 am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@72636c 72636c changed the title deps: skuba 7.1.1 fix: Adjust code for typescript-eslint v6 rules Aug 16, 2023
@72636c 72636c requested a review from a team as a code owner August 16, 2023 21:06
@renovate
Copy link
Contributor Author

renovate bot commented Aug 16, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@72636c 72636c merged commit 512963b into master Aug 17, 2023
5 checks passed
@72636c 72636c deleted the renovate-skuba-7.x branch August 17, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants