deps: skuba 7.0.1 (#212)

* deps: skuba 7.0.1 * Node 18 * Fix noUncheckedIndexedAccess issues --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tomas Bolger <tbolger@seek.com.au>
seek-oss · Jul 26, 2023 · e653343 · e653343
1 parent d52bbc0
commit e653343
Show file tree

Hide file tree

Showing 7 changed files with 1,577 additions and 1,652 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -20,10 +20,10 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Set up Node.js 16.x
+      - name: Set up Node.js 18.x
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile

diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
@@ -16,10 +16,10 @@ jobs:
       - name: Check out repo
         uses: actions/checkout@v3
 
-      - name: Set up Node.js 16.x
+      - name: Set up Node.js 18.x
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.x
 
       - name: Install dependencies
         run: yarn install --frozen-lockfile

diff --git a/.prettierignore b/.prettierignore
@@ -1,17 +1,4 @@
 # managed by skuba
-.idea/*
-.vscode/*
-
-.cdk.staging/
-.serverless/
-cdk.out/
-node_modules*/
-
-/coverage*/
-/dist*/
-/lib*/
-/tmp*/
-
 # Gantry resource files support non-standard template syntax
 /.gantry/**/*.yaml
 /.gantry/**/*.yml

diff --git a/package.json b/package.json
@@ -38,7 +38,7 @@
     "datadog-lambda-js": "6.89.0",
     "dd-trace": "3.28.0",
     "hot-shots": "10.0.0",
-    "skuba": "6.2.0"
+    "skuba": "7.0.1"
   },
   "peerDependencies": {
     "datadog-lambda-js": "6.x || 7.x",

diff --git a/src/createCloudWatchClient.test.ts b/src/createCloudWatchClient.test.ts
@@ -20,8 +20,8 @@ describe('createCloudWatchClient', () => {
     it('should record integer timings without tags', () => {
       metricsClient.timing('my_custom_metric', 100);
 
-      expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|100|histogram|test.my_custom_metric|#env:jest
         "
       `);
@@ -31,7 +31,9 @@ describe('createCloudWatchClient', () => {
       metricsClient.timing('my_custom_metric', 1234.5, ['pipe|special|char']);
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|1234.5|histogram|test.my_custom_metric|#env:jest,pipe_special_char
         "
       `);
@@ -43,7 +45,8 @@ describe('createCloudWatchClient', () => {
       metricsClient.histogram('my_custom_metric', 100);
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|100|histogram|test.my_custom_metric|#env:jest
         "
       `);
@@ -55,7 +58,8 @@ describe('createCloudWatchClient', () => {
       ]);
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|1234.5|histogram|test.my_custom_metric|#env:jest,pipe_special_char
         "
       `);
@@ -67,7 +71,8 @@ describe('createCloudWatchClient', () => {
       metricsClient.increment('my_custom_metric');
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|1|count|test.my_custom_metric|#env:jest
         "
       `);
@@ -77,7 +82,8 @@ describe('createCloudWatchClient', () => {
       metricsClient.increment('my_custom_metric', ['comma,special,char']);
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|1|count|test.my_custom_metric|#env:jest,comma_special_char
         "
       `);
@@ -87,7 +93,8 @@ describe('createCloudWatchClient', () => {
       metricsClient.increment('my_custom_metric', 10);
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|10|count|test.my_custom_metric|#env:jest
         "
       `);
@@ -97,7 +104,8 @@ describe('createCloudWatchClient', () => {
       metricsClient.increment('my_custom_metric', 10, ['compound:tag']);
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|10|count|test.my_custom_metric|#env:jest,compound:tag
         "
       `);
@@ -109,7 +117,8 @@ describe('createCloudWatchClient', () => {
       metricsClient.decrement('my_custom_metric');
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|-1|count|test.my_custom_metric|#env:jest
         "
       `);
@@ -119,7 +128,8 @@ describe('createCloudWatchClient', () => {
       metricsClient.decrement('my_custom_metric', 10);
 
       expect(stdoutSpy).toHaveBeenCalledTimes(1);
-      expect(stdoutSpy.mock.calls[0][0]).toMatchInlineSnapshot(`
+      const [buffer] = stdoutSpy.mock.calls[0] ?? [];
+      expect(buffer).toMatchInlineSnapshot(`
         "MONITORING|31337|-10|count|test.my_custom_metric|#env:jest
         "
       `);

diff --git a/src/createTimedSpan.test.ts b/src/createTimedSpan.test.ts
@@ -30,15 +30,15 @@ describe('timedSpan', () => {
 
     expect(mockIncrement).toHaveBeenCalledTimes(1);
     {
-      const [name, tags] = mockIncrement.mock.calls[0];
+      const [name, tags] = mockIncrement.mock.calls[0] ?? [];
 
       expect(name).toBe('test.count');
       expect(tags).toEqual(['success']);
     }
 
     expect(mockTiming).toHaveBeenCalledTimes(1);
     {
-      const [name, latency] = mockTiming.mock.calls[0];
+      const [name, latency] = mockTiming.mock.calls[0] ?? [];
 
       expect(name).toBe('test.latency');
       expect(latency).toBeGreaterThanOrEqual(0);
@@ -150,15 +150,15 @@ describe('timedSpan', () => {
 
     expect(mockIncrement).toHaveBeenCalledTimes(1);
     {
-      const [name, tags] = mockIncrement.mock.calls[0];
+      const [name, tags] = mockIncrement.mock.calls[0] ?? [];
 
       expect(name).toBe('test.count');
       expect(tags).toEqual(['failure']);
     }
 
     expect(mockTiming).toHaveBeenCalledTimes(1);
     {
-      const [name, latency] = mockTiming.mock.calls[0];
+      const [name, latency] = mockTiming.mock.calls[0] ?? [];
 
       expect(name).toBe('test.latency');
       expect(latency).toBeGreaterThanOrEqual(0);