metrics: Update apple system font metrics #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45abbcf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jahredhope
reviewed
Apr 15, 2024
jahredhope
approved these changes
Apr 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metrics: Update apple system font metrics
Previously the metrics provided for
-apple-systemandBlinkMacSystemFontwere extracted from theSF Profont, with a custom override to correct thedescentmetric.Through work to support metrics for different font weights and styles, it was identified that MacOS uses the
SFNSfont.Extracting the metrics from this font means no more custom overrides, and will now enable using this font as a fallback via postscript name soon too.
SF Pro Metrics
SF Pro Metrics (with
descentoverride)SFNS Metrics