Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Handle system and google font inputs uniformly #188

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

michaeltaranto
Copy link
Contributor

In preparation for supporting metrics for font variants (eg. weight and style), this refactors how metrics are extracted and built internally.

Key goals were:

  • Normalise system fonts and google fonts data structures
  • Pre-extract metrics from google fonts
  • Generate script can just read(not extract) metrics for all font sources

@michaeltaranto michaeltaranto requested a review from a team as a code owner April 10, 2024 00:58
Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: 04db46e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌👌👌👌👌👌

@michaeltaranto michaeltaranto merged commit ce7dcb7 into master Apr 11, 2024
6 checks passed
@michaeltaranto michaeltaranto deleted the extract-all-fonts-uniformly branch April 11, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants