Don't print contents of secret values with '\n' characters. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@72636c Are you still looking after this repo? Does the above make sense? |
72636c
reviewed
Dec 18, 2023
There was a problem hiding this comment.
Thanks for the catch @michaelbiriley!
Would you be up to add a test case to ensure this doesn't regress in future? I'm thinking we could use assert_output without --partial.
There was a problem hiding this comment.
Good idea. Please see below.. it was a bit fiddly to deal with the bash color code characters.. but I got there in the end.
Let me know if there are any blockers to merging. 🙏
…erflow multiline value also expand test # detection to be able to define double digit tests.
72636c
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Thanks for your contribution and patience @michaelbiriley 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that one of our secrets was showing immediately in the logs. :(
The secret is a private key. It is a JSON value that contains
\nin the string.This tweak means that the command that sed processes is limited to the first line of the 'raw' string.
Problematic output:
