enabling prefetched deps #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gregory-Pereira
force-pushed
the
release-1.0.gamma-enable-hermetic-and-prefetched-deps-builds
branch
5 times, most recently
from
b1035a3 to
d4dcf1e
Compare
|
/retest |
Gregory-Pereira
force-pushed
the
release-1.0.gamma-enable-hermetic-and-prefetched-deps-builds
branch
3 times, most recently
from
d1dc80f to
ece5150
Compare
lance
reviewed
Nov 30, 2023
| WORKDIR /tmp | ||
|
|
||
| RUN curl -sL https://github.com/jqlang/jq/releases/download/jq-1.6/jq-linux64 -o /tmp/jq && chmod 755 /tmp/jq && \ | ||
| curl -sL https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable/openshift-client-linux.tar.gz -o /tmp/openshift-client-linux.tar.gz && \ |
There was a problem hiding this comment.
These commands won't work with hermetic builds. I think you should remove that from the pipelines. :(
Gregory-Pereira
force-pushed
the
release-1.0.gamma-enable-hermetic-and-prefetched-deps-builds
branch
13 times, most recently
from
2e6d92d to
6740eb4
Compare
Gregory-Pereira
changed the title
Gregory-Pereira
force-pushed
the
release-1.0.gamma-enable-hermetic-and-prefetched-deps-builds
branch
from
6740eb4 to
0c19088
Compare
Gregory-Pereira
merged commit 09e235b
into
securesign:release-1.0.gamma
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will not be able to do hermetic builds for this component.
/cc @tommyd450
/cc @lance