Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop md5 and sha1 schemes from supported key schemes #554

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

ckilcoin
Copy link

Fixes: #512

Drop md5 and sha1 schemes from supported key schemes without changing keys/ module.

Please verify and check that the pull request fulfils the following requirements:

  • The code follows the Code Style Guidelines
  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

Tested by running tox -e py311, no additional tests needed since it is a removal of schemes.

@jku
Copy link
Collaborator

jku commented Mar 30, 2023

Quick comment:

This is probably still fine: nobody should be using these hash algorithms in the year 2023 (the theoretical danger is that existing keys used somewhere could stop working because of this... but I do think it's theoretical)

@lukpueh opinions?

@jku
Copy link
Collaborator

jku commented Mar 30, 2023

Also, please have a look at the lint results (you can check them locally too with tox -e lint)

@lukpueh
Copy link
Member

lukpueh commented Mar 30, 2023

This is probably still fine: nobody should be using these hash algorithms in the year 2023 (the theoretical danger is that existing keys used somewhere could stop working because of this... but I do think it's theoretical)

Agreed. IMO annoying potential users of md5, sha1 is a fair risk for us to take.

Copy link
Collaborator

@jku jku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukpueh lukpueh merged commit f3e3f12 into secure-systems-lab:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop md5 and sha1 schemes from supported key schemes
3 participants