Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GPGSigner.sign return Signature #486

Merged
merged 4 commits into from
Jan 11, 2023

Commits on Dec 14, 2022

  1. signer: move GPGSigner to _gpg_signer.py

    Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
    lukpueh committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    2af35f9 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. signer: make GPGSigner.sign return Signature

    Adds two private conversion helpers to translate from the old
    signature format to Signature and vice-versa, i.e.
    - change "signature" field name to "sig",
    - list additional gpg signature field "other_headers" under
      Signature's "unrecognized_fields"
    
    The helpers are used in GPGSigner.sign and (in a follow-up PR)
    in GPGKey.verify_signature.
    
    Also removes the no longer needed GPGSignature class.
    
    Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
    lukpueh committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    d70a244 View commit details
    Browse the repository at this point in the history
  2. signer: polish GPGSigner docs

    Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
    lukpueh committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2a22f9f View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. signer: add GPG signature data structure test

    Assert that GPG Signature instances have the correct extra field,
    and test conversion to and from legacy format.
    
    Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
    lukpueh committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    863ebeb View commit details
    Browse the repository at this point in the history