Fix RSA PSS salt lengths #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
reviewed
Aug 4, 2022
There was a problem hiding this comment.
Thanks, @trishankatdatadog. Great patch and issue/pr description!
Can automatically verify RSA PSS signatures regardless of the input salt length
Testing that would indeed be great. Do you have capacities?
Done. PTAL? |
lukpueh
approved these changes
Aug 9, 2022
There was a problem hiding this comment.
Thanks for adding tests, @trishankatdatadog! Left two non-blocking comments inline.
lukpueh
reviewed
Aug 11, 2022
|
@lukpueh OK, done, simplified tests, PTAL, thx! |
- use maximum salt length by default when creating sigs - use automatic salt length inferred from sigs when verifying this should be the simplest, backwards-compatible, and secure way to verify cross-platform RSA PSS signatures, especially with Golang crypto/rsa
trishankatdatadog
force-pushed
the
trishankatdatadog/rsassa-pss-salt-lengths
branch
from
2b94e8e
to
1811500
Compare
trishankatdatadog
deleted the
trishankatdatadog/rsassa-pss-salt-lengths
branch
|
Thanks, Lukas! Could we please get a release? Cc @yzhan289 |
3 tasks
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Oct 13, 2022
In secure-systems-lab#422 we changed `create_rsa_signature` to use the maximum salt length available, instead of the digest length, when creating rsassa-pss signatures, and adapted `verify_rsa_signature` to infer the salt length automatically. This made it impossible for users of the old verify function, which could only handle digest sized salts, to verify signatures created by users of the new signing function (see secure-systems-lab#430). Since the advantage of max salt lengths is mostly academic, this patch reverts `create_rsa_signature` to use digest sized salts. Note that we now use the `padding.PSS.DIGEST_LENGTH` constant instead of passing the actual digest length, as we did before. Using the constant has the same result, but is recommended by the library documentation. Also note that the patch does not revert the `verify_rsa_signature` part of secure-systems-lab#422. This allows verifying signatures created with the securesystemslib release that used max salt lengths, or created outside of securesystemslib. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh
added a commit
to lukpueh/securesystemslib
that referenced
this pull request
Oct 13, 2022
In secure-systems-lab#422 we changed `create_rsa_signature` to use the maximum salt length available, instead of the digest length, when creating rsassa-pss signatures, and adapted `verify_rsa_signature` to infer the salt length automatically. This made it impossible for users of the old verify function, which could only handle digest sized salts, to verify signatures created by users of the new signing function (see secure-systems-lab#430). Since the advantage of max salt lengths is mostly academic, this patch reverts `create_rsa_signature` to use digest sized salts (as agreed in secure-systems-lab#431). Note that we now use the `padding.PSS.DIGEST_LENGTH` constant instead of passing the actual digest length, as we did before. Using the constant has the same result, but is recommended by the library documentation. Also note that the patch does not revert the `verify_rsa_signature` part of secure-systems-lab#422. This allows verifying signatures created with the securesystemslib release that used max salt lengths, or created outside of securesystemslib. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #421
Description of the changes being introduced by the pull request:
This PR does two things:
This should be the simplest, most backwards-compatible, and yet most secure way to verify cross-platform RSA PSS signatures.
Missing tests
Please verify and check that the pull request fulfils the following requirements: