Canonical encoding speedup by using str.replace #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace regex substitute with string replace method to encode 'string' to canonical string format. add test case to verify the method
lukpueh
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Great work, @PradyumnaKrishna! Judging from the Python docs, these two should always have the same result.
This was referenced Jun 8, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #372
Description of the changes being introduced by the pull request:
The
_canonical_string_encoder()uses regex for string substitution in encoding the string to canonical form. The regex code is replaced bystr.replacemethod which is faster in comparison of regex substitution. Few more test conditions are added.Please verify and check that the pull request fulfils the following requirements: