Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Limit build-on-push to master branch only #335

Merged

Conversation

jku
Copy link
Collaborator

@jku jku commented Feb 17, 2021

Dependabot pushes to main repository and ends up triggering two builds
every time (one for PR, one for push): limit the rule for build-on-push
to apply to master branch only.

If release branches are used later on they should be added to list here.


This was already done in TUF: we can wait for dependabot to react to the daily cryptography release (sigh) to see if the TUF version works correctly before merging this...

@jku
Copy link
Collaborator Author

jku commented Feb 17, 2021

we can wait for dependabot to react to the daily cryptography release (sigh) to see if the TUF version works correctly before merging this...

All good, marking this not-a-draft

@jku jku marked this pull request as ready for review February 17, 2021 10:34
@jku jku marked this pull request as draft February 17, 2021 10:35
Dependabot pushes to main repository and ends up triggering two builds
every time (one for PR, one for push): limit the rule for build-on-push
to apply to master branch only.

If release branches are used later on they should be added to list here.
@jku jku changed the title CI: Limit build-on-push to develop branch only CI: Limit build-on-push to master branch only Feb 17, 2021
@jku jku force-pushed the build-on-push-to-develop-only branch from 07ab2a6 to 7de4893 Compare February 17, 2021 10:36
@jku jku marked this pull request as ready for review February 17, 2021 10:36
Copy link
Collaborator

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix.

@joshuagl joshuagl merged commit a7d3668 into secure-systems-lab:master Feb 17, 2021
@lukpueh lukpueh mentioned this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants