Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinue pycrypto support #56

Closed
lukpueh opened this issue Sep 12, 2017 · 4 comments
Closed

Discontinue pycrypto support #56

lukpueh opened this issue Sep 12, 2017 · 4 comments

Comments

@lukpueh
Copy link
Member

lukpueh commented Sep 12, 2017

pycrypto which we provided as crypto backend alongside pyca/cryptography is no longer maintained (tip of master 3 years old and usage discouraged in issue tracker).

We should probably replace it with the drop-in replacement pycryptodome or drop it altogether?

@vladimir-v-diaz
Copy link
Contributor

It makes sense to switch to pycryptodome, or similar, if PyCrypto is truly no longer maintained (rather than stable and no longer accepting feature requests).

I would rather provide multiple library options rather than relying on a single crypto library. If a user doesn't want to use a supported library, they can choose another. If a feature provided by some library is insecure, we should obviously avoid that feature in those cases.

The more options and freedom to choose, the better IMO.

This was referenced Sep 15, 2017
@vladimir-v-diaz
Copy link
Contributor

@JustinCappos @lukpueh
I don't recall, but did you recommend that we remove support for multiple crypto backends (just use pyca/cryptograpy) or that we use pycryptodome instead of PyCrypto?

@lukpueh
Copy link
Member Author

lukpueh commented Sep 21, 2017

As far as I can remember we just agreed to remove pycrypto.

I personally don't see the huge benefit of providing multiple alternatives. Especially since we can only provide it for some of securesystemslib's functionality (rsa keys).

vladimir-v-diaz added a commit that referenced this issue Sep 28, 2017
Remove PyCrypto dependency and multi-library support.  Address issue #56.
@vladimir-v-diaz
Copy link
Contributor

PyCrypto and multi-library support was removed in #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants