Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge-develop-to-public #389

Merged
merged 182 commits into from
Oct 8, 2024
Merged

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Oct 8, 2024

Created by merge-to-remote.sh

victorkirov and others added 30 commits June 21, 2024 14:46
make rune market data floor price property optional
Fix the send ordinals method and add tests - ENG-3940
…ect-signmessage-let-developers-select-the-signature

mahmoud/eng-4642-sats-connect-signmessage-let-developers-select-the-signature
Add swaps endpoints to xverse client
Allow identifying signing indexes via nonWitnessUtxo
github-actions bot and others added 25 commits September 19, 2024 16:32
Co-authored-by: GitHub Actions Bot <>
* Add fee rate to parsed
psbt

* Add aggregated txn summary

* add script and scriptHex to outputs

* Complete summaries

* Fix tests

* Add runes to bundles

* Remove rune parsing for only internal inputs to transfers

* export to index

* export to index

* Add a few missing fields for the views and 2 todos

* Split aggregated summary into payments and ordinals addresses

* Fix invalid mint logic

* export raw inputs/outputs

* Update utils/transactionSummary/index.ts

* fix logic

* Add user aggregate to no external inputs summary

* fix logic

* small touchups

* export type definitions

* add comments

* fix breaking error

* fix issue where rune transfer is not being accounted for in bundle

* remove console

* chore: move some utils from clients to core

* touch styling

* remove async modifier for not needed

* update typing

* revert changes for a better solution

* remove comments

* handle sats padding logic when combining both btc & ordinal address

* add documentation

* add comment

* fix rare sats aggregation bug

* remove comments

* touchup comments

* integrate new change

* Don't fail if we can't estimate PSBT size

* Remove cross address btc amounts difference

* Fix spacing to improve readability

* Extract types

* touch up

* Add base64 to hex util

* Add hex to base64

* Wrong branch

* Fix imports

---------

Co-authored-by: Terence Ng <ngtere@live.com.sg>
Co-authored-by: fede erbes <fedeerbes@gmail.com>
* add new currencies

* remove unsupported currencies

* Update currency.ts

* fix up list

* Update currency.ts
* add new currencies

* remove unsupported currencies

* Update currency.ts

* fix up list

* Update currency.ts

* fix chf fiat symbol
Co-authored-by: GitHub Actions Bot <>
* Improve keeping the cache clean and add mutexes

* Add retry on rate limit for esplora API

* Ensure we don't run getUtxo if cache is initialising

* Add write lock on init write

* Switch back to address mutex

---------

Co-authored-by: fede erbes <fedeerbes@gmail.com>
Co-authored-by: GitHub Actions Bot <>
Co-authored-by: GitHub Actions Bot <>
…functionality-from-ext-to-core

[ENG-5340] Export necessary functionality from the extension to core
* Remove a bunch of unused code

* Improved RBF order

* Ensure stx tests don't make api calls

* Update brc20 1 step to use new code and remove old btc code

* Delete tests for removed code and fix import

* Fix brc-20 tests

* Clean up more tests

* clean up ledger code

* Add codecs

* Fix imports

* Remove unused param in CompileOptions type for RBF

---------

Co-authored-by: fede erbes <fedeerbes@gmail.com>
Co-authored-by: GitHub Actions Bot <>
* refactor: gather fungible token derived state into one place

and add unit tests

* refactor: add visible back and deprecate it so PR core is not breaking change

* chore: readability

Co-authored-by: Victor Kirov <victor.kirov@gmail.com>

* fix: move the logic to always support runes tokens to be clearer

* chore: add comments and readability

* chore: extend manageTokens type to cater for tokens that were not set yet

---------

Co-authored-by: Victor Kirov <victor.kirov@gmail.com>
Co-authored-by: fede erbes <fedeerbes@gmail.com>
Copy link
Contributor

github-actions bot commented Oct 8, 2024

📊 Test Coverage

  • Line Coverage: 64.36%
  • Statement Coverage: 64.36%
  • Branch Coverage: 79.74%
  • Function Coverage: 38.26%

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Test this PR with npm i --save-exact @secretkeylabs/xverse-core@24.2.0-23a063f

@teebszet teebszet merged commit 1f51eab into develop Oct 8, 2024
3 checks passed
@teebszet teebszet deleted the chore/merge-develop-to-public-1728374181 branch October 8, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants