This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
Deprecate wrapping of errors with errio.Error() #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wrapping leads to appending "An unexpected error occurred [...]" to many errors, even ones that are relatively simple. The only way to avoid this, is to return all errors as errrio.PublicError; this does not work well togehter with the error paradigm introduced in Go 1.13.
SimonBarendse
approved these changes
Nov 24, 2020
| return err | ||
| } | ||
| return UnexpectedError(err) | ||
| return err |
There was a problem hiding this comment.
Not sure if we should change the behavior as well. Should we just deprecate and stop calling the function where we need the changed behavior?
One might depend on the returned type being UnexpectedError, as this was explicitly documented and a separate test case exists for this, TestUnexpectedError.
|
Had to consider @SimonBarendse thought for a few times. In the end, I think there is an easy solution that keeps the current exported behaviour by leveraging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapping leads to appending "An unexpected error occurred [...]" to many errors, even ones that are relatively simple. The only way to avoid this, is to return all errors as errrio.PublicError; this does not work well togehter with the error paradigm introduced in Go 1.13.