This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Update secret not found error message #172
Merged
SimonBarendse
merged 9 commits into
develop
from
feature/improved-secret-not-found-error
Mar 18, 2020
Merged
Update secret not found error message #172
SimonBarendse
merged 9 commits into
develop
from
feature/improved-secret-not-found-error
Mar 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mackenbach
reviewed
Feb 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to make this available for all usage of secrets 😄
I've some suggestions and a question about the impact of this change.
golangcibot
reviewed
Mar 4, 2020
golangcibot
reviewed
Mar 4, 2020
SimonBarendse
approved these changes
Mar 4, 2020
golangcibot
reviewed
Mar 4, 2020
This PR requires the go version of the client to be updated to 1.13 |
…ecret-not-found-error
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
secret not found
error will now include the path of the secret. For example: