Add iterator functions #163

Marton6 · 2019-12-20T10:57:37Z

No description provided.

…or-functions

SimonBarendse

Nice!

Let's think about the default values before releasing this though.

We can now also deprecate the list functions. You can read here: https://github.com/golang/go/wiki/Deprecated how to do this. And see some examples here: https://golang.org/search?q=Deprecated:

pkg/secrethub/acl.go

pkg/secrethub/org.go

pkg/secrethub/org_member.go

pkg/secrethub/repo.go

pkg/secrethub/org.go

pkg/secrethub/acl.go

pkg/secrethub/org.go

pkg/secrethub/iterator/paginator.go

pkg/secrethub/iterator/iterator_test.go

SimonBarendse

Update iterators to use the http client

Why did you do this? Does this change behavior? I liked how we could re-use the logic that is already in the List functions.

pkg/secrethub/acl.go

Fix bug in access rule iterator

…po service

pkg/secrethub/repo.go

pkg/secrethub/secret_version.go

pkg/secrethub/service.go

SimonBarendse · 2020-01-24T12:27:28Z

@Marton6 We still need to deprecate the list functions: #163 (review)

SimonBarendse

Sweet! 👍 Just one thing

pkg/secrethub/secret.go

mackenbach

Discussed this in person and it has been approved! 👍

SimonBarendse · 2020-02-10T17:26:04Z

@mackenbach Is anything holding this from being merged?

mackenbach · 2020-02-11T08:42:59Z

Nope, I just left the timing of the merge to @Marton6 because it looked like there was a dependency. Merged it now.

Marton6 added 11 commits December 19, 2019 15:01

Add acl iterator

7d945ed

Add acl access level iterator

2f74f23

Add repo iterator to RepoService and MeService

b6d8fc6

Add repo iterators for repo service and me service

a2962ec

Update access rule and access level iterators

d8ba77f

Add org iterator

2371156

Add org member iterator

5886ec1

Add repo account iterator

6001aab

Add repo service iterator and service iterator

05c1ed4

Add repo user iterator

5ece0c0

Add secret version iterator

6b73131

SimonBarendse changed the title ~~Feature/add iterator functions~~ Add iterator functions Dec 20, 2019

Update Fakes

b584203

Marton6 requested a review from SimonBarendse December 20, 2019 12:06

Merge remote-tracking branch 'origin/develop' into feature/add-iterat…

e08e263

…or-functions

SimonBarendse reviewed Dec 20, 2019

View reviewed changes

mackenbach reviewed Dec 20, 2019

View reviewed changes

pkg/secrethub/org.go Show resolved Hide resolved

Marton6 added 4 commits December 21, 2019 15:20

Add example for directory creation

c199a7a

Fix typo

6b152cb

Rephrase comment

d9e7d1e

Fix comment

d61b326

SimonBarendse reviewed Dec 23, 2019

View reviewed changes

pkg/secrethub/acl.go Outdated Show resolved Hide resolved

pkg/secrethub/org.go Show resolved Hide resolved

Marton6 added 2 commits December 23, 2019 10:13

Fix typo

d66b45b

Update AccessRule iterator to use paginator

bf60f28

SimonBarendse reviewed Dec 27, 2019

View reviewed changes

pkg/secrethub/iterator/paginator.go Outdated Show resolved Hide resolved

Rename PaginatorConstructorWithFetch to PaginatorFactory

0b0f928

golangcibot reviewed Jan 6, 2020

View reviewed changes

pkg/secrethub/iterator/paginator.go Outdated Show resolved Hide resolved

pkg/secrethub/iterator/iterator_test.go Outdated Show resolved Hide resolved

Marton6 added 3 commits January 6, 2020 16:18

Export parameters of access rule iterator

08298fe

Run goimports

3e47a5d

Add access level iterator

74f2922

Marton6 added 6 commits January 7, 2020 11:06

Simplify access rule iterator default parameter assignment

219af25

Update account iterator param names

ae91082

Fix account iterator params

ed47f9c

Add org iterator params to org iterator

917e7e0

Update iterators to use the http client

c69ad65

Fix org service mock

3363a2a

SimonBarendse reviewed Jan 7, 2020

View reviewed changes

pkg/secrethub/acl.go Outdated Show resolved Hide resolved

Marton6 added 2 commits January 7, 2020 19:08

Fix casting bug in most iterators

de541a8

Fix bug in access rule iterator

Add namespace to repo iterator params and remove IteratorMine from re…

1f2d5f7

…po service

golangcibot reviewed Jan 7, 2020

View reviewed changes

pkg/secrethub/repo.go Outdated Show resolved Hide resolved

pkg/secrethub/repo.go Show resolved Hide resolved

Marton6 added 4 commits January 9, 2020 14:04

Add default params for secret version iterator when nil is provided

1c20bed

Fix error not checked

8553a8b

Simplify error handling in repo service iterator

75448fd

Simplify access level iterator default parameter assignment

8049283

SimonBarendse reviewed Jan 9, 2020

View reviewed changes

pkg/secrethub/secret_version.go Outdated Show resolved Hide resolved

pkg/secrethub/secret_version.go Outdated Show resolved Hide resolved

pkg/secrethub/service.go Show resolved Hide resolved

Marton6 added 4 commits January 9, 2020 17:29

Improve secret version iterator godoc

376d204

Fix secret version iterator godoc

96f5848

Improve godoc comment

d06192d

Improve secret version iterator godoc

81a06d0

Deprecate list functions

3a76eaf

SimonBarendse reviewed Jan 30, 2020

View reviewed changes

pkg/secrethub/secret.go Outdated Show resolved Hide resolved

Remove 'deprecated' comment from SecretService ListEvents

c65034b

mackenbach approved these changes Feb 5, 2020

View reviewed changes

mackenbach merged commit 86a3081 into develop Feb 11, 2020

mackenbach deleted the feature/add-iterator-functions branch February 11, 2020 08:42

SimonBarendse mentioned this pull request Mar 23, 2020

Release v0.27.0 #180

Merged

SimonBarendse mentioned this pull request Jun 26, 2020

GCP Linking #195

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add iterator functions #163

Add iterator functions #163

Marton6 commented Dec 20, 2019

SimonBarendse left a comment

SimonBarendse left a comment

SimonBarendse commented Jan 24, 2020

SimonBarendse left a comment

mackenbach left a comment

SimonBarendse commented Feb 10, 2020

mackenbach commented Feb 11, 2020

Add iterator functions #163

Add iterator functions #163

Conversation

Marton6 commented Dec 20, 2019

SimonBarendse left a comment

Choose a reason for hiding this comment

SimonBarendse left a comment

Choose a reason for hiding this comment

SimonBarendse commented Jan 24, 2020

SimonBarendse left a comment

Choose a reason for hiding this comment

mackenbach left a comment

Choose a reason for hiding this comment

SimonBarendse commented Feb 10, 2020

mackenbach commented Feb 11, 2020