-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kyscia-envoy 适配ARM64 适配官网拉取镜像编译构建,本地编译构建。 #10
Conversation
executor: [ "linux_x64_executor", "linux_aarch64_executor" ] | ||
parameters: | ||
arch: [ "amd64", "arm64" ] | ||
- docker_image_publish: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
镜像推送只在打tag时触发,加个filter
.circleci/config.yml
Outdated
docker: | ||
- image: secretflow/ubuntu-base-ci:latest | ||
resource_class: arm.2xlarge | ||
parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arm 参数没有必要了,根据 executor 环境自动获取
steps: | ||
- checkout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里 checkout 步骤为啥删除了
.circleci/config.yml
Outdated
shell: /bin/bash --login -eo pipefail | ||
|
||
commands: | ||
build-envoy: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
统一用下划线分割 build_envoy
.circleci/config.yml
Outdated
- store_artifacts: | ||
path: build_apps | ||
|
||
jobs: | ||
linux_publish: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
名字最好还是要贴合实际的动作,增加可读性,这里主要做的是 build envoy binary。linux_build_envoy
.circleci/config.yml
Outdated
- linux_publish: | ||
matrix: | ||
executor: [ "linux_x64_executor", "linux_aarch64_executor" ] | ||
parameters: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
去除 arch 参数配置,统一使用 matrix parameters , 按照这个改一下吧 https://github.com/secretflow/serving/blob/main/.circleci/release-config.yml
.circleci/config.yml
Outdated
- run: | ||
name: Build envoy | ||
name: "Build envoy" | ||
command: | | ||
git submodule update --init | ||
git config --global --add safe.directory ./ | ||
bazel build //:envoy -c opt --ui_event_filters=-info,-debug,-warning --jobs 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel build
这句换成 make build-envoy-local
#.circleci/config.yml 自动化构建镜像过程 #Dockerfile构建镜像过程 #Makefile构建镜像过程
#Makefile中ARCH参数amd64 arm64兼容性
#Makefile中ARCH参数amd64 arm64兼容性
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
I have read the CLA Document and I hereby sign the CLA
添加Linux aarch64 适配官网拉取镜像编译构建,本地编译构建。
添加Mac m1 arm64 适配官网拉取镜像编译构建,本地编译构建。