Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kyscia-envoy 适配ARM64 适配官网拉取镜像编译构建,本地编译构建。 #10

Closed
wants to merge 22 commits into from

Conversation

wangzul
Copy link
Contributor

@wangzul wangzul commented Apr 1, 2024

I have read the CLA Document and I hereby sign the CLA
添加Linux aarch64 适配官网拉取镜像编译构建,本地编译构建。
添加Mac m1 arm64 适配官网拉取镜像编译构建,本地编译构建。

executor: [ "linux_x64_executor", "linux_aarch64_executor" ]
parameters:
arch: [ "amd64", "arm64" ]
- docker_image_publish:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

镜像推送只在打tag时触发,加个filter

docker:
- image: secretflow/ubuntu-base-ci:latest
resource_class: arm.2xlarge
parameters:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arm 参数没有必要了,根据 executor 环境自动获取

steps:
- checkout
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 checkout 步骤为啥删除了

shell: /bin/bash --login -eo pipefail

commands:
build-envoy:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一用下划线分割 build_envoy

- store_artifacts:
path: build_apps

jobs:
linux_publish:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

名字最好还是要贴合实际的动作,增加可读性,这里主要做的是 build envoy binary。linux_build_envoy

- linux_publish:
matrix:
executor: [ "linux_x64_executor", "linux_aarch64_executor" ]
parameters:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

去除 arch 参数配置,统一使用 matrix parameters , 按照这个改一下吧 https://github.com/secretflow/serving/blob/main/.circleci/release-config.yml

- run:
name: Build envoy
name: "Build envoy"
command: |
git submodule update --init
git config --global --add safe.directory ./
bazel build //:envoy -c opt --ui_event_filters=-info,-debug,-warning --jobs 16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bazel build 这句换成 make build-envoy-local

Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@wangzul
❌ @wzl01859889
wzl01859889 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

wzl01859889 and others added 5 commits April 24, 2024 11:06
This reverts commit 60f179c.
This reverts commit 938afa0.
This reverts commit fea8bd4.
This reverts commit 60f179c.
@wangzul wangzul closed this Apr 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants