theoretical earlier start to asset downloads during startup #3589
+146
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewMeadows
commented
Feb 20, 2025
| @@ -348,8 +348,6 @@ std::string gLastVersionChannel; | |||
| LLVector3 gWindVec(3.0, 3.0, 0.0); | |||
| LLVector3 gRelativeWindVec(0.0, 0.0, 0.0); | |||
|
|
|||
| U32 gPacketsIn = 0; | |||
There was a problem hiding this comment.
This was never actually used. It looks like old debug cruft that someone forgot to remove.
AndrewMeadows
commented
Feb 20, 2025
| } | ||
| // ...then call display_startup() | ||
| display_startup(); | ||
| } |
There was a problem hiding this comment.
A wrapper for display_startup() that tries to process UDP packets, but only during a particular startup STATE wiindow. Hrm... I thought I had left a comment here about why I was bracketing the work between STATE_AGENT_SEND and STATE_PRECACHE, but I seem to have lost it. I will add it back.
AndrewMeadows
force-pushed
the
leviathan/faster-startup
branch
from
39f1193 to
90139f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seemed like maybe we could start processing UDP messages a little earlier during the startup sequence, however I wasn't able to measure much improvement: there was just too much noise during login. Some logins go faster than others both with or without these changes.