#3466 Crash at LLScrollingPanelParam::draw #3479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-productengine
force-pushed
the
maxim/ForeverFPS-3466
branch
from
992b3df to
78fee73
Compare
marchcat
approved these changes
Jan 27, 2025
akleshchev
approved these changes
Jan 28, 2025
akleshchev
reviewed
Jan 28, 2025
| doOnIdleOneTime([force_restrictions,enforce_ordering,post_update_func]() | ||
| { | ||
| LLAppearanceMgr::instance().updateAppearanceFromCOF(force_restrictions, enforce_ordering, post_update_func); | ||
| }); |
There was a problem hiding this comment.
Another way to do it is by posting to mMainQueue
maxim-productengine
merged commit 43a966e
into
release/2024.12-ForeverFPS
11 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although I wasn't able to repro the crash itself,
llassert(LLCoros::on_main_coro());consistently triggered when trying to follow the steps according to the logs:Sol let's avoid calling the update inside coro.