Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesh loading optimizations #3488

Open
akleshchev opened this issue Jan 29, 2025 · 1 comment
Open

Mesh loading optimizations #3488

akleshchev opened this issue Jan 29, 2025 · 1 comment
Assignees
@akleshchev
Labels
enhancement New feature or request triage Flags issues that need to be triaged

Comments

@akleshchev
Copy link
Contributor

akleshchev commented Jan 29, 2025 •
edited
Loading

Mesh thread is very busy on a region of moderate size on AMD Ryzen 7 3800X
Image

  1. Fix disk usage
    Mesh thread reads from disk to check if file in cashe has data and reads whole lod segment in one go only then requests data from network. Disk operations are expensive so it's better to minimize them and only read disk when it's has something to read. Like when we are reading header, get information about presense of lods too.

  2. Threading
    Thread appears to be busy all the time, which should be affecting speed of processing meshes negatively. A lot of expensive operations, like meshes' cacheOptimize don't need to happen here

  3. Doublecheck mutexes
@akleshchev akleshchev added enhancement New feature or request triage Flags issues that need to be triaged labels Jan 29, 2025
@akleshchev akleshchev self-assigned this Jan 30, 2025
akleshchev added a commit that referenced this issue Jan 30, 2025
@akleshchev
#3488 Make mesh_header_map a bit simpler
ac8faa3 
preparation for further work
akleshchev added a commit that referenced this issue Jan 30, 2025
@akleshchev
#3488 WIP avoid reading from disk when no nessesary
067b0fc 
LLMeshHeaderHandler preallocates file with empty data, there is no point
reading large empty sections so write presense flags at the start of the
file
akleshchev added a commit that referenced this issue Jan 30, 2025
@akleshchev
#3488 WIP avoid reading from disk when no nessesary
601a5ae 
LLMeshHeaderHandler preallocates file with empty data, there is no point
reading large empty sections so write presense flags at the start of the
file
akleshchev added a commit that referenced this issue Jan 30, 2025
@akleshchev
#3488 WIP avoid reading from disk when no nessesary
af97e6b 
LLMeshHeaderHandler preallocates file with empty data, there is no point
reading large empty sections so write presense flags at the start of the
file
akleshchev added a commit that referenced this issue Jan 30, 2025
@akleshchev
#3488 WIP avoid reading from disk when no nessesary
2c077a3 
LLMeshHeaderHandler preallocates file with empty data, there is no point
reading large empty sections so write presense flags at the start of the
file
akleshchev added a commit that referenced this issue Jan 30, 2025
@akleshchev
#3488 Make mesh_header_map a bit simpler
f9a78c8 
preparation for further work
akleshchev added a commit that referenced this issue Jan 30, 2025
@akleshchev
#3488 Avoid reading meshes from disk when not nessesary
f487c84 
LLMeshHeaderHandler preallocates file with empty data, there is no point
reading large empty sections so write presense flags at the start of the
file
akleshchev added a commit that referenced this issue Jan 31, 2025
@akleshchev
#3488 Minimize allocations
48c9910
akleshchev added a commit that referenced this issue Jan 31, 2025
@akleshchev
#3488 Make mesh_header_map a bit simpler
52fb53a 
preparation for further work
akleshchev added a commit that referenced this issue Jan 31, 2025
@akleshchev
#3488 Avoid reading meshes from disk when not nessesary
c405cd3 
LLMeshHeaderHandler preallocates file with empty data, there is no point
reading large empty sections so write presense flags at the start of the
file
akleshchev added a commit that referenced this issue Jan 31, 2025
@akleshchev
#3488 Minimize allocations
e979768
akleshchev added a commit that referenced this issue Jan 31, 2025
@akleshchev
#3488 Fix last retry not saving handle
314ef53 
Request was sent and handle is valid, save it
akleshchev added a commit that referenced this issue Jan 31, 2025
@akleshchev
#3488 Split mesh thread mutexes
beb8ead 
Tracy shows that thread waits a lot on mutexes.
Split in and out mutexes, so that new work can be scheduled by main
thread without blocking handling
@akleshchev
Copy link
Contributor Author

Performance wise just resolving some mutexes and fixing extra disk reads turned to be surprisingly effective. "wait" is the thread having free time instead of a solid line of 'mesh_thread_loop'.
I do not see any obvious issues inworld, so it's time to test if avatar loading is any faster now that thread can keep up. If it helps, will improve threading.

Image

akleshchev added a commit that referenced this issue Feb 3, 2025
@akleshchev
#3488 Split mesh thread mutexes
33303b9 
Tracy shows that thread waits a lot on mutexes.
Split in and out mutexes, so that new work can be scheduled by main
thread without blocking handling
akleshchev added a commit that referenced this issue Feb 3, 2025
@akleshchev
#3488 Move lod processing out of mesh thread
7eb9dd3
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix mesh header condition
c61185b
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix mesh header condition
f5f98e1
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix mesh header condition
42fce46
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix mesh header condition
8226642
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 mutex lock mSkinMap
1f561fd
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix cache using wrong offset
6a1ec6b
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 mutex lock mSkinMap
2dd5cf1
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix cache using wrong offset
34154ef
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix skin info not reading from cache
c010880
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Part of skin info processing out of mesh thread
c331e00 
Skin info parsing is expensive, offload to thread pool
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 #3488 Move skin info processing out of mesh thread
785623e 
Skin info parsing is expensive, offload to thread pool
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 #3488 Move skin info processing out of mesh thread
8dcd5a7 
Skin info parsing is expensive, offload to thread pool
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 mutex lock mSkinMap
587444b
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix cache using wrong offset
912c99a
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Fix skin info not reading from cache
8c4abf8
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 #3488 Move skin info processing out of mesh thread
9bfdb7c 
Skin info parsing is expensive, offload to thread pool
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Speed up nearby avatar loading after a tp
a0a4ff0
akleshchev added a commit that referenced this issue Feb 4, 2025
@akleshchev
#3488 Speed up nearby avatar loading after a tp
15a41a3
akleshchev added a commit that referenced this issue Feb 5, 2025
@akleshchev
#3488 Speed up nearby avatar loading after a tp
74d2ed9
akleshchev added a commit that referenced this issue Feb 6, 2025
@akleshchev
#3488 Debug avatar attachmets
971fb5d
akleshchev added a commit that referenced this issue Feb 6, 2025
@akleshchev
#3488 Debug avatar attachmets
a31ddd5
akleshchev added a commit that referenced this issue Feb 6, 2025
@akleshchev
#3488 Debug avatar attachmets
c5414f4
akleshchev added a commit that referenced this issue Feb 6, 2025
@akleshchev
#3488 Debug avatar attachmets
366af6a
akleshchev added a commit that referenced this issue Feb 6, 2025
@akleshchev
#3488 Debug avatar attachmets
05d770b
akleshchev added a commit that referenced this issue Feb 7, 2025
@akleshchev
#3488 Prioritization adjustments
78fc484
akleshchev added a commit that referenced this issue Feb 7, 2025
@akleshchev
#3488 Prioritization adjustments
7d42a1e
akleshchev added a commit that referenced this issue Feb 7, 2025
@akleshchev
#3488 Prioritization adjustments
d8c5dae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akleshchev akleshchev

Labels
enhancement New feature or request triage Flags issues that need to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akleshchev