Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "remote-theme" & add scapy-awesome #26

Merged
merged 3 commits into from
Apr 26, 2020
Merged

Use "remote-theme" & add scapy-awesome #26

merged 3 commits into from
Apr 26, 2020

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Apr 7, 2020 •
edited
Loading

This allows to not store the theme ourselves, but rather use the foreign one.

guedou
guedou approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@guedou guedou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool PR!

You should transfer the ownership of awesome-scapy to secdev. I will contribute my list of tools =)

Do yo want me to wait for this change to be done before merging this PR?

@gpotter2
Copy link
Member Author

gpotter2 commented Apr 8, 2020

I moved it but lost all admin permissions on it.
If you could fix that it would be great. Same for this repo actually

@guedou
Copy link
Member

guedou commented Apr 8, 2020

Done on both repo.

@p-l-
Copy link
Member

p-l- commented Apr 17, 2020

Should we merge now or wait and change the remote-theme?

@gpotter2
Copy link
Member Author

gpotter2 commented Apr 17, 2020 •
edited
Loading

Let's try to have it fixed first

@gpotter2 gpotter2 force-pushed the master branch 2 times, most recently from 595d2c8 to 7d510dc Compare April 25, 2020 12:41
@gpotter2
Copy link
Member Author

The PR was merged and the theme updated. This should be ready to go

@gpotter2 gpotter2 merged commit 908b0b7 into secdev:master Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-l- p-l- p-l- approved these changes

@guedou guedou guedou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gpotter2 @guedou @p-l-