Fix ElseIfStatement double-evaluation in awaited context #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code in awaited context check caused
elseIf.WriteToAsync
to always start writing, even when it should be only started if condition is true:Parametrized test case to test async and non-async paths the get some red tests and then fixed. Now passing the
elseIf
and write task is retrieved, if needed.We found out this when running on Linux against sync code, which was quite curious, on Windows it always worked.