Fixed wrong message in ConstraintTestCase #3534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SelfDescribing test was reporting lack of implementation of the \Countable class not the SelfDescribing class. While not a problem, it would be at least misleading to contributors seeing the error.
Codecov Report
@@ Coverage Diff @@
## master #3534 +/- ##
=========================================
Coverage 82.92% 82.92%
Complexity 3709 3709
=========================================
Files 144 144
Lines 9673 9673
=========================================
Hits 8021 8021
Misses 1652 1652Continue to review full report at Codecov.
|
|
Merged manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SelfDescribing test was reporting lack of implementation of the
\Countable class not the SelfDescribing class. While not a problem, it
would be at least misleading to contributors seeing the error.
Since this is a TestCase I could not find any tests to update.