introduce 'requires OSFAMILY' #2722
Conversation
composer.json
Outdated
| @@ -37,7 +37,7 @@ | |||
| "phpunit/phpunit-mock-objects": "^4.0", | |||
| "sebastian/comparator": "^2.0", | |||
| "sebastian/diff": "^1.4.3 || ^2.0", | |||
| "sebastian/environment": "^3.0.2", | |||
| "sebastian/environment": "^3.1@dev", | |||
There was a problem hiding this comment.
Could 3.1 be deployed ?
alternatively, I could use php polyfilled constant from symfony/polyfill.
There was a problem hiding this comment.
3.1.0 has been released
Codecov Report
@@ Coverage Diff @@
## master #2722 +/- ##
============================================
+ Coverage 55.4% 55.41% +0.01%
- Complexity 2762 2765 +3
============================================
Files 102 102
Lines 7229 7231 +2
============================================
+ Hits 4005 4007 +2
Misses 3224 3224
Continue to review full report at Codecov.
|
|
Yes, I'll release 3.1 shortly. I wanted to wait a while until the constant's value for Apple had settled. |
src/Util/Test.php
Outdated
| ? $matches['value'][$i] | ||
| : \sprintf( | ||
| '/%s/i', | ||
| \addcslashes($matches['value'][$i], '/') |
There was a problem hiding this comment.
logic when to use strictly provided value and when to decorate it for regex matching can be moved direct to place, when we compare the 'OS' value. I'm for that movement, but with that, we would need to update all related tests (to not contain /Linux/i but just Linux). WDYT @sebastianbergmann ?
|
Makes sense to me. |
Closes #2697