Make json assertions stricter #2241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assertJsonStringEqualsJsonString and assertJsonStringNotEqualsJsonString didn't use the same JsonMatches constraint as the other json assertions. Update them to use the same constraint so its implementation can be consistently updated.
The JsonMatches constraint considered the following strings equal.
{ "number": 5 }
{ "number": "5" }
These are different objects in JSON, because the values have different
basic types. Change from using a simple (==) comparison of objects in
PHP to a strategy where the JSON is canonicalized and then the
reformatted strings are compared.
|
Merged manually, thanks. |
sebastianbergmann
added
the
type/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1629 rebased onto the latest master as I ran into the same issues that @kalenp did. I'm hoping no additional work would be required but if so let me know.