Fixed a bug in PHPUnit_Framework_Constraint_Count #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For instances of Iterator, it called [iterator_count](php.net/manual/en/function.iterator-count.php), which (unfortunately) changes the instance's key. This fix `rewind`s the iterator's key to where it was
sebastianbergmann
added a commit
that referenced
this pull request
Jan 30, 2014
Fixed a bug in PHPUnit_Framework_Constraint_Count
|
Thank you for your contribution! |
|
Gern geschehen! |
jmikola
added a commit
to jmikola/phpunit
that referenced
this pull request
May 22, 2017
This allows generators (sebastianbergmann#2149) and internal Traversables (sebastianbergmann#2642) to be properly detected before attempting to restore the Iterator's position after counting (sebastianbergmann#1125).
This was referenced May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For instances of Iterator, it called iterator_count,
which (unfortunately) changes the instance's key. This fix
rewinds the iterator's key to where it was.See #1124