Do not use the ternary operator

sebastianbergmann · Sep 9, 2024 · c2dc716 · c2dc716
1 parent 1c004af
commit c2dc716
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/Framework/Constraint/Callback.php b/src/Framework/Constraint/Callback.php
@@ -42,7 +42,7 @@ public function toString(): string
     /**
      * @psalm-suppress ArgumentTypeCoercion
      */
-    public function hasVariadicParam(): bool
+    public function isVariadic(): bool
     {
         foreach ((new ReflectionFunction($this->callback))->getParameters() as $parameter) {
             if ($parameter->isVariadic()) {
@@ -63,8 +63,10 @@ public function hasVariadicParam(): bool
      */
     protected function matches(mixed $other): bool
     {
-        return $this->hasVariadicParam()
-            ? ($this->callback)(...$other)
-            : ($this->callback)($other);
+        if ($this->isVariadic()) {
+            return ($this->callback)(...$other);
+        }
+
+        return ($this->callback)($other);
     }
 }
diff --git a/src/Framework/MockObject/Runtime/Rule/Parameters.php b/src/Framework/MockObject/Runtime/Rule/Parameters.php
@@ -109,7 +109,7 @@ private function doVerify(): bool
         }
 
         foreach ($this->parameters as $i => $parameter) {
-            if ($parameter instanceof Callback && $parameter->hasVariadicParam()) {
+            if ($parameter instanceof Callback && $parameter->isVariadic()) {
                 $other = $this->invocation->parameters();
             } else {
                 $other = $this->invocation->parameters()[$i];