Support for "Globstar" pattern #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 13, 2024 11:44
Added support for globstar when resolving paths in the FileIterator factory. The extended glob function was adapted from funkjedi's implementation: https://gist.github.com/funkjedi/3feee27d873ae2297b8e2370a7082aad Fixed facade test to include newly created fixture directories.
Removed unnecessary formatting changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 38 44 +6
===========================================
Files 4 4
Lines 95 114 +19
===========================================
+ Hits 95 114 +19 ☔ View full report in Codecov by Sentry. |
|
@funkjedi This PR copies your code from https://gist.github.com/funkjedi/3feee27d873ae2297b8e2370a7082aad. Are you okay with that? |
|
rock and roll |
sebastianbergmann
changed the title
added 3 commits
August 14, 2024 08:25
Fixed static code analysis errors.
Added check to make sure $files isn't false when sorting the array. Otherwise, we return an empty array.
Ignore coverage for the last line of the globstar function, since it's only used if the glob function returns an error. Added a test to validate the behaviour of the globstar function when passing non existant glob pattern. Fixed code using php-cs-fixer. Fixed error reported by phpstan.
|
I was having a pretty hard time with the GitHub checks until I realized that the tools used were in the |
|
Would love to see this land in PHPUnit! |
nicDamours
deleted the
feature/#82-add-support-for-globstar-in-file-iterator-factory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for globstar pattern when resolving paths in the FileIterator Factory.
A globstar can now be added to a filter's path to recursively search for a given directory in a structure. The globstar can be use like that:
This pattern will look into every directory under
root_directory, recursively, and return the path of eachtarget_directorypresent in the structure.Fixes #82