Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tests #132

Merged
merged 8 commits into from
Jun 10, 2024
Merged

Simplify tests #132

merged 8 commits into from
Jun 10, 2024

Conversation

sebastian-toepfer
Copy link
Owner

No description provided.

@sebastian-toepfer sebastian-toepfer added this to the 0.3.0 milestone Jun 6, 2024
@sebastian-toepfer sebastian-toepfer force-pushed the simplify_tests branch 2 times, most recently from 4786d20 to 4ba8073 Compare June 8, 2024 15:35
VocabularyDefinition is a interface now, the default implemention move
into LazyVocabularyDefinition which no longer use the serviceloader
directly. the vocabulary avaivable for a definitions will provided via a
supplier. ServiceLoaderLazyVocabulariesSupplier can be use to use a
ServiceLoader to find a requested vocabulary.
VocabularyDefinition doesn't provide a method to retrieve the id instead
it defines a method to ask if it has a given id (hasId("") instead of
id().equals("")).
Copy link

@sebastian-toepfer sebastian-toepfer marked this pull request as ready for review June 10, 2024 19:12
@sebastian-toepfer sebastian-toepfer merged commit 9114ca6 into main Jun 10, 2024
2 checks passed
@sebastian-toepfer sebastian-toepfer deleted the simplify_tests branch June 10, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant