Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax errors fail silently #209

Merged
merged 1 commit into from
Jan 10, 2014

Conversation

klieber
Copy link
Collaborator

@klieber klieber commented Jan 10, 2014

Hi team,

I have recently made a syntax mistake while writing unit test:
describe('some class', function {});

Is it expected that this file is just skipped and there is no error output, if it is run through mvn test ?

@klieber
Copy link
Collaborator

klieber commented Nov 22, 2013

Where is the syntax error? Just because you don't define any tests doesn't make it a syntax error, it's just empty and therefore no tests are run.

@VladyslavGoloshchapov
Copy link
Author

sorry - I must have been more clear, the syntax error is in function declaration:
function {} - the () is missing

@klieber
Copy link
Collaborator

klieber commented Nov 22, 2013

ah! or I could have looked at it longer.

@VladyslavGoloshchapov
Copy link
Author

:)

@VladyslavGoloshchapov
Copy link
Author

anyway - is there a way to stop build instead of swallowing it silently ?

@klieber
Copy link
Collaborator

klieber commented Nov 22, 2013

I'm not sure why it isn't causing a failure because it definitely should fail on syntax errors. Most likely a bug somewhere.

@VladyslavGoloshchapov
Copy link
Author

is it reproducible on your environment, Kyle ?

@ghost ghost assigned klieber Jan 10, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.31%) when pulling a1ef3f6 on klieber:issue/209_syntax_errors_should_fail into 6e27461 on searls:master.

klieber added a commit that referenced this pull request Jan 10, 2014
@klieber klieber merged commit 602b840 into searls:master Jan 10, 2014
@klieber klieber deleted the issue/209_syntax_errors_should_fail branch February 18, 2014 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants