-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a serverHostname property to AbstractJasmineMojo. Useful when using... #198
Conversation
…ng the RemoteWebDriver.
Just some more information on why we needed this, and why it seems like a good thing to have. We use the selenium Remote Web Driver from Jenkins to run our tests against various browser types / versions / OSs. Without this setting, the plugin always tried to connect to localhost:, but with the remote web driver, it wouldn't be on localhost, it would be on a remote ip address. I left the default to be localhost, so it shouldn't break any existing setups. If you need anything else, have any issues with this change - just let me know. |
* <p>The <code>jasmine:test</code> goal to specify hostname where the server is running. Useful when using | ||
* the RemoteWebDriver.</p> | ||
* | ||
* @since 1.3.1.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.3.1.3 has been released already. This will need to be updated to 1.3.1.4
Add a serverHostname property to AbstractJasmineMojo.
Thanks! |
@skrall Two questions for you:
|
There is a Java property that selenium looks at if no URL is passed into a RemoteWebDriver. I believe it's See code here. But I do think your new property is much easier, I like it. As for the various browsers / os, I was lucky, we only have to support one browser / version. But it's not the same version of the OS that our tests ran on. So we needed the RemoteWebDriver. But if I had to support multiple, I would do what you have done with the profiles. |
Hum... the mystery is solved...
:) Thanks! |
@tfga Did your remoteWebDriverUrl property ever make it into any searls 1.3.1.x releases? If not, did you just use the -Dwebdriver.remote.server property? Thanks in advance! |
No, it didn't. The project seems dead.
No, I'm using my fork. I published it internally with a different |
... the RemoteWebDriver.