Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https connections? #184

Merged
merged 1 commit into from
Jan 9, 2014
Merged

Conversation

klieber
Copy link
Collaborator

@klieber klieber commented Jan 9, 2014

It seems Internet explorer needs the client to be on an HTTPS server in order to connect to HTTPS, which makes sense (oddly, chrome and firefox while using this plugin don't care somehow). Is there an option to enable SSL for the jetty server?
Or is it possible to at least override the configuration of the jetty server being used? I'm not exactly a maven expert so am not sure if this is possible..

@ghost
Copy link
Author

ghost commented Jul 17, 2013

jasmine-maven-plugin / src / main / java / com / github / searls / jasmine / server / ServerManager.java

private int startServer(int port) throws Exception {
Connector connector = new SelectChannelConnector();

If there were a way to get us to be able to choose whether that is a SelectChannelConnector or sslSelectChannelConnector, I believe that would solve my problem.

@ghost
Copy link
Author

ghost commented Aug 9, 2013

made a fix of my own. using SslSelectChannelConnector fixed my problem, as i expected.

@klieber
Copy link
Collaborator

klieber commented Aug 18, 2013

@gerahe it would be great if you could submit a pull request.

@ghost
Copy link
Author

ghost commented Aug 19, 2013

i'm not too experienced with git haha, so when i figure out how i'll try to do so.

@ghost ghost assigned klieber Jan 9, 2014
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.33%) when pulling d7caabd on klieber:issue/184_https_support into 5425526 on searls:master.

@klieber
Copy link
Collaborator

klieber commented Jan 9, 2014

The jetty connector can now be customized with the connectorClass parameter.

<plugin>
  <groupId>com.github.searls</groupId>
  <artifactId>jasmine-maven-plugin</artifactId>
  <version>${jasmine-maven-plugin.version}</version>
  <executions>
    <execution>
      <goals>
        <goal>test</goal>
      </goals>
    </execution>
  </executions>
  <configuration>
    <connectorClass>org.eclipse.jetty.server.ssl.SslSelectChannelConnector</connectorClass>
  </configuration>
</plugin>

klieber added a commit that referenced this pull request Jan 9, 2014
adding support for changing the jetty connector
@klieber klieber merged commit 6e27461 into searls:master Jan 9, 2014
@klieber klieber deleted the issue/184_https_support branch February 18, 2014 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants