Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pymarkdownlnt from 0.9.21 to 0.9.22 #247

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2024

Bumps pymarkdownlnt from 0.9.21 to 0.9.22.

Release notes

Sourced from pymarkdownlnt's releases.

Version 0.9.22 - Date: 2024-08-05

This release was focused on enabling fixing for Rule Md031 and uncovering any issues with the more deeply nested container cases. The good news is that, as the list in the fixed section shows, we fixed a lot of issues. The better news is that only a handful of those fixes dealt with the parser, with the bulk of the issues dealing with transitioning from Markdown to our internal token format and back to Markdown again.

Why is this important? When a user asks the PyMarkdown linter to fix any issues that it can, our team wants to have the utmost confidence that PyMarkdown is producing the correct fix. Therefore, we tokenize the Markdown and base our rules off tokens that we know are correct. The only way to validate that we have the correct tokens is to take those tokens and recreate the Markdown. If we cannot produce the exact Markdown that we started with, then we have a problem.

In most of the fixed issues below, the tokens are correct and can produce the proper HTML from the Markdown. However, in over 90% of the fixed issues below, when we recreate the Markdown, the Markdown that we produce if off by a couple of whitespace characters. For the reasons stated above, it is important to our team to fix these issues with transparency. Therefore, while the fixed list is somewhat long, it is an honest reflection of the issues that we found and addressed.

Added

Fixed

  • Issue 1120
    • within Block-List, thematic break can sometimes not report newlines to the list block
  • Issue 1122
    • opening a fenced code block in a Bq-List-Bq was closing the outer BQ
  • Issue 1123
    • in some cases within a Bq-List-Bq, not counting the newlines properly
  • Issue 1124
    • list items within a Bq-List-Bq can have incorrect starting text regarding the innermost block
  • Issue 1125
    • parsing of blank lines within Bq-List-Bq does not always add the right newlines to the list
  • Issue 1126
    • under some circumstances, with a Bq-List-Bq, thematic break can cause the block quote to close
  • Issue 1127
    • rehydration can be wrong with indented blocks in Bq-List-Bq
  • Issue 1130
    • check for adding extra line to list with blank line in *-List-Bq not flexible enough
  • Issue 1132
    • false positives (negatives?) for list looseness fixed
  • Issue 1135
    • fixed issue introduced with above shortcuting in Bq-List-Bq scenarios to avoid assert
  • Issue 1137
    • fixed issue with hanging indents and some Bq-List-Bq scenarios
  • Issue 1141
    • fixed assert with Bq-List-Bq with previously untested branch
  • Issue 1142

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @seapagan.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Aug 12, 2024
Copy link

codacy-production bot commented Aug 12, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c985ccf) 95 94 98.95%
Head commit (7308578) 95 (+0) 94 (+0) 98.95% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#247) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@dependabot dependabot bot force-pushed the dependabot/pip/pymarkdownlnt-0.9.22 branch from 4706195 to f568ca8 Compare August 20, 2024 20:45
@seapagan
Copy link
Owner

@dependabot squash and merge

@seapagan
Copy link
Owner

@dependabot rebase

Bumps [pymarkdownlnt](https://github.com/jackdewinter/pymarkdown) from 0.9.21 to 0.9.22.
- [Release notes](https://github.com/jackdewinter/pymarkdown/releases)
- [Changelog](https://github.com/jackdewinter/pymarkdown/blob/main/changelog.md)
- [Commits](jackdewinter/pymarkdown@v0.9.21...v0.9.22)

---
updated-dependencies:
- dependency-name: pymarkdownlnt
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/pymarkdownlnt-0.9.22 branch from 7d1998e to 3e8520a Compare August 20, 2024 21:04
@seapagan seapagan merged commit 9e73d36 into main Aug 20, 2024
11 checks passed
@seapagan seapagan deleted the dependabot/pip/pymarkdownlnt-0.9.22 branch August 20, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant